fix: issue gh-2005

[nklinkachevAtVMware]

Customizing VMs ( customize{} block in the spec) with a hardware version less than 10 fails due to formatting error of the version string passed in the API. Changed the formatting code to format the version to 2 digit integer, left padded with 0 when it's less than 10. That way version 9 becomes vmx-09 instead of vmx-9 and version 10 remains vmx-10.

Description

Fix: r/vsphere_virtual_machine Customization fails with when the hardware version of the machine is less than 10.
"Error: cannot find OS family for guest ID "": ServerFaultCode: A specified parameter was not correct: key"

Acceptance tests

• Have you added an acceptance test for the functionality being added?
• Have you run the acceptance tests on this branch?

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'
no regressions

Release Note

Release note for CHANGELOG:

resource/vsphere_virtual_machine: Customization fails when hardware version of the machine is less than 10. [#2009](https://github.com/hashicorp/terraform-provider-vsphere/pull/2009)

References

[hashicorp-cla]

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes

_{Have you signed the CLA already but the status is still pending? Recheck it.}

[appilon]

I will run the VM resource tests on your branch, great job this has been a bug forever.

UPDATE: no regressions for existing VM tests

[tenthirtyam]

@nklinkachevAtVMware Can you ensure that the commit is signed and that you have signed the CLA?

[appilon]

replacing with #2011 due some unfortunate timeline limitations.

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.