Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests/r/fsx: Add sweeper concurrency #18626

Merged
merged 3 commits into from
Apr 7, 2021
Merged

tests/r/fsx: Add sweeper concurrency #18626

merged 3 commits into from
Apr 7, 2021

Conversation

YakDriver
Copy link
Member

@YakDriver YakDriver commented Apr 7, 2021 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #15334

Output from acceptance testing: N/A

@YakDriver YakDriver requested a review from a team as a code owner April 7, 2021 17:55
@ghost ghost added size/M Managed by automation to categorize the size of a PR. service/fsx Issues and PRs that pertain to the fsx service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Apr 7, 2021
@YakDriver YakDriver mentioned this pull request Apr 7, 2021
Closed
@bflad bflad self-assigned this Apr 7, 2021
bflad
bflad approved these changes Apr 7, 2021
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🚀

aws/resource_aws_fsx_lustre_file_system_test.go Outdated
input := &fsx.DescribeFileSystemsInput{}

err = conn.DescribeFileSystemsPages(input, func(page *fsx.DescribeFileSystemsOutput, lastPage bool) bool {
err = conn.DescribeFileSystemsPages(input, func(page *fsx.DescribeFileSystemsOutput, isLast bool) bool {
Copy link
Contributor

@bflad bflad Apr 7, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Prevalent convention for anonymous paginator functions is to name the 2nd parameter lastPage

Of course there's no enforcement so it is murky:

$ ag --stats-only 'Pages\(.*lastPage'
227 matches

$ ag --stats-only 'Pages\(.*isLast'  
84 matches

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh no!!! I was just going on the contributing docs and changed all the WAFs the wrong way!

@YakDriver YakDriver added this to the v3.36.0 milestone Apr 7, 2021
@YakDriver YakDriver merged commit 4684db0 into main Apr 7, 2021
@YakDriver YakDriver deleted the t-concsweep-fsx branch April 7, 2021 20:42
This was referenced Apr 7, 2021
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@ghost
Copy link

ghost commented Apr 9, 2021

This has been released in version 3.36.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented May 8, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators May 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees

@bflad bflad

Labels
service/fsx Issues and PRs that pertain to the fsx service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.36.0
Development

Successfully merging this pull request may close these issues.
2 participants
@YakDriver @bflad