Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prefer lastPage for pagination, R #18650

Merged
merged 11 commits into from
Apr 14, 2021
Merged

Prefer lastPage for pagination, R #18650

merged 11 commits into from
Apr 14, 2021

Conversation

YakDriver
Copy link
Member

@YakDriver YakDriver commented Apr 8, 2021 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #17936
Relates #18626

Output from acceptance testing: N/A (handled by nightly)

@YakDriver YakDriver requested a review from a team as a code owner April 8, 2021 02:05
@ghost ghost added size/M Managed by automation to categorize the size of a PR. service/ec2 Issues and PRs that pertain to the ec2 service. service/kafka Issues and PRs that pertain to the kafka service. service/neptune Issues and PRs that pertain to the neptune service. service/redshift Issues and PRs that pertain to the redshift service. service/route53 Issues and PRs that pertain to the route53 service. service/route53resolver Issues and PRs that pertain to the route53resolver service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Apr 8, 2021
ewbankkit
ewbankkit approved these changes Apr 14, 2021
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (pending merge conflict in .semgrep.yml).

@ewbankkit ewbankkit self-assigned this Apr 14, 2021
@YakDriver YakDriver force-pushed the td-semgrep-pages-lastPage3 branch from db37160 to 3769ced Compare April 14, 2021 21:48
@ghost ghost added size/S Managed by automation to categorize the size of a PR. and removed size/M Managed by automation to categorize the size of a PR. labels Apr 14, 2021
@YakDriver YakDriver added this to the v3.37.0 milestone Apr 14, 2021
@YakDriver YakDriver merged commit a2f99e9 into main Apr 14, 2021
@YakDriver YakDriver deleted the td-semgrep-pages-lastPage3 branch April 14, 2021 22:52
@ghost
Copy link

ghost commented Apr 16, 2021

This has been released in version 3.37.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented May 15, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators May 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees

@ewbankkit ewbankkit

Labels
service/ec2 Issues and PRs that pertain to the ec2 service. service/kafka Issues and PRs that pertain to the kafka service. service/neptune Issues and PRs that pertain to the neptune service. service/redshift Issues and PRs that pertain to the redshift service. service/route53resolver Issues and PRs that pertain to the route53resolver service. service/route53 Issues and PRs that pertain to the route53 service. size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.37.0
Development

Successfully merging this pull request may close these issues.
2 participants
@YakDriver @ewbankkit