Prefer use of lastPage in pagination functions

[YakDriver]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #18626
Relates #17936

Output from acceptance testing:

--- PASS: TestAccAWSStepFunctionsActivityDataSource_basic (29.55s)

--- PASS: TestAccDataSourceAwsEc2ManagedPrefixList_matchesTooMany (4.53s)
--- PASS: TestAccDataSourceAwsEc2ManagedPrefixList_filter (20.42s)
--- PASS: TestAccDataSourceAwsEc2ManagedPrefixList_basic (20.76s)

[ewbankkit]

LGTM (pending merge conflict in .semgrep.yml).

% make testacc TEST=./aws TESTARGS='-run=TestAccDataSourceAwsEc2ManagedPrefixList_basic\|TestAccAWSInstancesDataSource_basic\|TestAccAWSRoute53ResolverRulesDataSource_basic\|TestAccAWSStepFunctionsActivityDataSource_basic\|TestAccAWSAPIGatewayV2ApisDataSource_Name\|TestAccAwsCurReportDefinition_basic\|TestAccAWSKinesisStream_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccDataSourceAwsEc2ManagedPrefixList_basic\|TestAccAWSInstancesDataSource_basic\|TestAccAWSRoute53ResolverRulesDataSource_basic\|TestAccAWSStepFunctionsActivityDataSource_basic\|TestAccAWSAPIGatewayV2ApisDataSource_Name\|TestAccAwsCurReportDefinition_basic\|TestAccAWSKinesisStream_basic -timeout 180m
=== RUN   TestAccAWSAPIGatewayV2ApisDataSource_Name
--- PASS: TestAccAWSAPIGatewayV2ApisDataSource_Name (27.23s)
=== RUN   TestAccDataSourceAwsEc2ManagedPrefixList_basic
=== PAUSE TestAccDataSourceAwsEc2ManagedPrefixList_basic
=== RUN   TestAccAWSInstancesDataSource_basic
=== PAUSE TestAccAWSInstancesDataSource_basic
=== RUN   TestAccAWSRoute53ResolverRulesDataSource_basic
=== PAUSE TestAccAWSRoute53ResolverRulesDataSource_basic
=== RUN   TestAccAWSStepFunctionsActivityDataSource_basic
=== PAUSE TestAccAWSStepFunctionsActivityDataSource_basic
=== RUN   TestAccAwsCurReportDefinition_basic
=== PAUSE TestAccAwsCurReportDefinition_basic
=== RUN   TestAccAWSKinesisStream_basic
=== PAUSE TestAccAWSKinesisStream_basic
=== CONT  TestAccDataSourceAwsEc2ManagedPrefixList_basic
=== CONT  TestAccAwsCurReportDefinition_basic
=== CONT  TestAccAWSRoute53ResolverRulesDataSource_basic
=== CONT  TestAccAWSInstancesDataSource_basic
=== CONT  TestAccAWSStepFunctionsActivityDataSource_basic
=== CONT  TestAccAWSKinesisStream_basic
--- PASS: TestAccAWSRoute53ResolverRulesDataSource_basic (9.15s)
--- PASS: TestAccAwsCurReportDefinition_basic (12.18s)
--- PASS: TestAccDataSourceAwsEc2ManagedPrefixList_basic (12.45s)
--- PASS: TestAccAWSStepFunctionsActivityDataSource_basic (20.67s)
--- PASS: TestAccAWSKinesisStream_basic (54.72s)
--- PASS: TestAccAWSInstancesDataSource_basic (324.09s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	354.231s

[ghost]

This has been released in version 3.37.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!