Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS SDK for Go v2 MaxBackoff delay to match AWS SDK for Go v1 default #36855

Merged
merged 5 commits into from
Apr 11, 2024

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Apr 11, 2024

Description

Sets the AWS SDK for Go v2 API client MaxBackoff to 300s, the AWS SDK for Go v1 default value.

Relations

Closes #36837.
Relates #36649.
Requires hashicorp/aws-sdk-go-base#1011.
Requires #36861.

Output from Acceptance Testing

% make sanity
make: sanity Check (48 tests of Top 30 resources)
make: like 'sane' but less output and runs all tests despite most errors
make: NOTE: NOT an exhaustive set of tests! Finds big problems only.
17 of 48 complete: 17 passed, 0 failed
33 of 48 complete: 33 passed, 0 failed
48 of 48 complete: 48 passed, 0 failed
Testing with FMS (#36649):
% AWS_DEFAULT_REGION=us-east-1 make testacc TESTARGS='-run=TestAccFMS_serial/AdminAccount/basic' PKG=fms
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.21.8 test ./internal/service/fms/... -v -count 1 -parallel 20  -run=TestAccFMS_serial/AdminAccount/basic -timeout 360m
=== RUN   TestAccFMS_serial
=== PAUSE TestAccFMS_serial
=== CONT  TestAccFMS_serial
=== RUN   TestAccFMS_serial/AdminAccount
=== RUN   TestAccFMS_serial/AdminAccount/basic
--- PASS: TestAccFMS_serial (1166.35s)
    --- PASS: TestAccFMS_serial/AdminAccount (1166.35s)
        --- PASS: TestAccFMS_serial/AdminAccount/basic (1166.35s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/fms	1178.508s

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/S Managed by automation to categorize the size of a PR. client-connections Pertains to the AWS Client and service connections. labels Apr 11, 2024
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Apr 11, 2024
@ewbankkit ewbankkit added the aws-sdk-go-migration Issues that are related to the providers migration to AWS SDK for Go v2. label Apr 11, 2024
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@ewbankkit
Copy link
Contributor Author

After official aws-sdk-go-base releases:

% make sanity
make: sanity Check (48 tests of Top 30 resources)
make: like 'sane' but less output and runs all tests despite most errors
make: NOTE: NOT an exhaustive set of tests! Finds big problems only.
17 of 48 complete: 17 passed, 0 failed
33 of 48 complete: 33 passed, 0 failed
48 of 48 complete: 48 passed, 0 failed

@ewbankkit ewbankkit merged commit ca464c0 into main Apr 11, 2024
35 checks passed
@ewbankkit ewbankkit deleted the f-config.MaxBackoff branch April 11, 2024 16:31
@github-actions github-actions bot added this to the v5.45.0 milestone Apr 11, 2024
github-actions bot pushed a commit that referenced this pull request Apr 11, 2024
Copy link

This functionality has been released in v5.45.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Apr 11, 2024
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
aws-sdk-go-migration Issues that are related to the providers migration to AWS SDK for Go v2. client-connections Pertains to the AWS Client and service connections. size/S Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MAX_BACKOFF changed between AWS SDK for Go v1 and v2
2 participants