-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fms: Migrate to aws-sdk-go-v2 #36649
Conversation
Community NoteVoting for Prioritization
For Submitters
|
Thank you for your contribution! 🚀 Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the Additional details:
|
# Conflicts: # go.mod # go.sum
This reverts commit ce57792.
85e4c20
to
7385756
Compare
…1c781a8f4e2bd20a9a52f68 && go mod tidy'.
…dcdea2111c781a8f4e2bd20a9a52f68 && go mod tidy'." This reverts commit 8fdbb27.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% ACCTEST_TIMEOUT=720m AWS_DEFAULT_REGION=us-east-1 make testacc TESTARGS='-run=TestAccFMS_serial' PKG=fms
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.21.8 test ./internal/service/fms/... -v -count 1 -parallel 20 -run=TestAccFMS_serial -timeout 720m
=== RUN TestAccFMS_serial
=== PAUSE TestAccFMS_serial
=== CONT TestAccFMS_serial
=== RUN TestAccFMS_serial/AdminAccount
=== RUN TestAccFMS_serial/AdminAccount/basic
=== RUN TestAccFMS_serial/AdminAccount/disappears
=== RUN TestAccFMS_serial/Policy
=== RUN TestAccFMS_serial/Policy/policyOption
policy_test.go:188: PolicyOption not returned from AWS API
=== RUN TestAccFMS_serial/Policy/resourceTags
=== RUN TestAccFMS_serial/Policy/tags
=== RUN TestAccFMS_serial/Policy/alb
=== RUN TestAccFMS_serial/Policy/basic
=== RUN TestAccFMS_serial/Policy/cloudfrontDistribution
=== RUN TestAccFMS_serial/Policy/disappears
=== RUN TestAccFMS_serial/Policy/includeMap
=== RUN TestAccFMS_serial/Policy/securityGroup
=== RUN TestAccFMS_serial/Policy/update
--- PASS: TestAccFMS_serial (25129.07s)
--- PASS: TestAccFMS_serial/AdminAccount (4734.99s)
--- PASS: TestAccFMS_serial/AdminAccount/basic (2287.52s)
--- PASS: TestAccFMS_serial/AdminAccount/disappears (2447.46s)
--- PASS: TestAccFMS_serial/Policy (20394.08s)
--- SKIP: TestAccFMS_serial/Policy/policyOption (0.00s)
--- PASS: TestAccFMS_serial/Policy/resourceTags (2149.50s)
--- PASS: TestAccFMS_serial/Policy/tags (2261.80s)
--- PASS: TestAccFMS_serial/Policy/alb (2404.42s)
--- PASS: TestAccFMS_serial/Policy/basic (2413.62s)
--- PASS: TestAccFMS_serial/Policy/cloudfrontDistribution (2391.54s)
--- PASS: TestAccFMS_serial/Policy/disappears (2096.62s)
--- PASS: TestAccFMS_serial/Policy/includeMap (2389.82s)
--- PASS: TestAccFMS_serial/Policy/securityGroup (2201.04s)
--- PASS: TestAccFMS_serial/Policy/update (2085.73s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/fms 25142.840s
@naruse666 Thanks for the contribution 🎉 👏. |
This functionality has been released in v5.46.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Relations
Closes #36162
References
Output from Acceptance Testing