Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAX_BACKOFF changed between AWS SDK for Go v1 and v2 #36837

Closed
ewbankkit opened this issue Apr 10, 2024 · 4 comments · Fixed by #36855
Closed

MAX_BACKOFF changed between AWS SDK for Go v1 and v2 #36837

ewbankkit opened this issue Apr 10, 2024 · 4 comments · Fixed by #36855
Assignees
Labels
aws-sdk-go-migration Issues that are related to the providers migration to AWS SDK for Go v2.
Milestone

Comments

@ewbankkit
Copy link
Contributor

ewbankkit commented Apr 10, 2024

The default MAX_BACKOFF value has changed between AWS SDK for Go v1 and v2.
For AWS SDK for Go v1 DefaultRetryerMaxRetryDelay is 300 seconds (5 minutes), whereas for AWS SDK for Go v2 DefaultMaxBackoff is 20 seconds.

This value determines the amount of time between API client request retries and the change in default means the that upgrade from AWS SDK for Go v1 to v2 for services (#32976) is not seamless.

Relates #36024.
Relates #36467.
Relates #34669 (comment).

Note that certain EC2 operations have a lower value: https://github.com/aws/aws-sdk-go/blob/9f6e3bb9f523aef97fa1cd5c5f8ba8ecf212e44e/service/ec2/customizations.go#L34-L46.

Copy link

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@ewbankkit ewbankkit changed the title MAX_BACKOFF changed between AWS SDK for Go v1 and v2 MAX_BACKOFF changed between AWS SDK for Go v1 and v2 Apr 10, 2024
@ewbankkit ewbankkit added the aws-sdk-go-migration Issues that are related to the providers migration to AWS SDK for Go v2. label Apr 10, 2024
@ewbankkit ewbankkit self-assigned this Apr 10, 2024
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Apr 10, 2024
Copy link

Warning

This issue has been closed, meaning that any additional comments are hard for our team to see. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

@github-actions github-actions bot added this to the v5.45.0 milestone Apr 11, 2024
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Apr 11, 2024
Copy link

This functionality has been released in v5.45.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
aws-sdk-go-migration Issues that are related to the providers migration to AWS SDK for Go v2.
Projects
None yet
1 participant