Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS SDK for Go v2 MaxBackoff delay to match AWS SDK for Go v1 default #1011

Merged
merged 6 commits into from
Apr 11, 2024

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Apr 10, 2024

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #1009.

Changes the AWS SDK for Go v2 MaxBackoff delay to 300 seconds, the AWS SDK for Go v1 default.

% go test ./...
?   	github.com/hashicorp/aws-sdk-go-base/v2/configtesting	[no test files]
?   	github.com/hashicorp/aws-sdk-go-base/v2/internal/awsconfig	[no test files]
?   	github.com/hashicorp/aws-sdk-go-base/v2/internal/constants	[no test files]
?   	github.com/hashicorp/aws-sdk-go-base/v2/internal/errs	[no test files]
?   	github.com/hashicorp/aws-sdk-go-base/v2/internal/slices	[no test files]
?   	github.com/hashicorp/aws-sdk-go-base/v2/internal/test	[no test files]
?   	github.com/hashicorp/aws-sdk-go-base/v2/mockdata	[no test files]
?   	github.com/hashicorp/aws-sdk-go-base/v2/servicemocks	[no test files]
ok  	github.com/hashicorp/aws-sdk-go-base/v2	5.940s
ok  	github.com/hashicorp/aws-sdk-go-base/v2/diag	(cached)
ok  	github.com/hashicorp/aws-sdk-go-base/v2/internal/config	0.717s
ok  	github.com/hashicorp/aws-sdk-go-base/v2/internal/endpoints	(cached)
ok  	github.com/hashicorp/aws-sdk-go-base/v2/internal/expand	(cached)
ok  	github.com/hashicorp/aws-sdk-go-base/v2/logging	0.595s
ok  	github.com/hashicorp/aws-sdk-go-base/v2/tfawserr	(cached)
ok  	github.com/hashicorp/aws-sdk-go-base/v2/useragent	0.777s
ok  	github.com/hashicorp/aws-sdk-go-base/v2/validation	(cached)

@ewbankkit ewbankkit requested a review from a team as a code owner April 10, 2024 20:34
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ewbankkit ewbankkit merged commit 23258f8 into main Apr 11, 2024
12 checks passed
@ewbankkit ewbankkit deleted the f-aws-sdk-go-v1-compatible-retry.MaxBackoff branch April 11, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default AWS SDK for Go v2 MaxBackoffDelay should match AWS SDK for Go v1 value
2 participants