Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of NET-4992- Kitchen sink gateway test into release/1.3.x #3206

Conversation

hc-github-team-consul-core

Backport

This PR is auto-generated from #3196 to be assessed for backporting due to the inclusion of the label backport/1.3.x.

The below text is copied from the body of the original PR.


Changes proposed in this PR:

  • Added acceptance test to utilize several API GW features at once. Potentially as time goes on we will need to add additional asserts, feature flags to this test to keep it up to date

How I've tested this PR:

  • Run the acceptance test locally

How I expect reviewers to test this PR:

  • CI test pass

Checklist:


Overview of commits

wilkermichael and others added 30 commits October 17, 2023 11:01
* Added jwt to routes for halting test

* GW Policy halting tests added
* prepare main for 1.4 dev

* add cloud tests

* add patch version for dataplane, now required.

* test: use only minor versions for tests

* build: remove last set-output from yaml

* add patch version for dataplane, now required.

* fixed error message change

---------

Co-authored-by: DanStough <dan.stough@hashicorp.com>
* kind of running

* WIP

* Unskip test and setup so it works correctly

* revert typo

* Move tokens into constants

* Adds test scenario for adding a second gateway policy to a gateway, should and will fail

* linter

* Add case for multiple routes on listener with only one defining JWT
configuration

* Multiple routes referencing the same external ref

* Add check for route referencing route extension outside of local
namespace failing

---------

Co-authored-by: Melisa Griffin <melisa.griffin@hashicorp.com>
* Remove copyright headers from externally-defined CRDs not owned by HashiCorp

* Make comment more accurate in .copywrite.hcl config

* Fix exclude path in .copywrite.hcl
* better handle gateway timeout errors

* strings not refs

* changelog

* Add missing import, fix import blocking

---------

Co-authored-by: Nathan Coleman <nathan.coleman@hashicorp.com>
…2946)

* Setup observability metrics tests

* Cleanup http_client.go and observability_test.go

* Refactor tests by using table driven approach

* Refactor and add comments to the client

* Remove param to token function

* remove consul export test redundant

* Remove hardcoded collector image

* Move metrics validation from server to consul-k8s tests and update to use the /records endpoint

* Change to achooo docker hub and fix lint errors
…44487) (#3139)

Bump google.golang.org/grpc to 1.56.3

This resolves [CVE-2023-44487](https://nvd.nist.gov/vuln/detail/CVE-2023-44487).

Also bump `consul-server-connection-manager` to latest to align with
that library's matching gRPC upgrade.
* Update kind to 1.28.0
Revert "Update chart version (#3152)"

This reverts commit fbf09e6.
* Add terminating gateway and external server to peering test

Add external server and terminating gateway to cluster peered acceptance test

* Export terminating gateway common functions

Write the new terminating gateway role

* Move other helper functions into the common file

Add service defaults and destination

Update terminating gateway section with proper config

Change the address we are trying to hit

Remove own external-server

WIP

* Move RegisterExternalService to helpers

Register external service for terminating gateway

Remove external static-server case

Remove tgw.yaml

* Add external services to exported services

* Remove the old test output

* Use HTTP instead of HTTPS for connection

* Clean up tests

* Remove test.sh

* Remove ip hostname

* Add a comment to RegisterExternalService

* Log the name of the service created in RegisterExternalService

* Apply suggestions from code review

Co-authored-by: Nathan Coleman <nathan.coleman@hashicorp.com>

* Move `terminatinggateway` to the correct import block

---------

Co-authored-by: Nathan Coleman <nathan.coleman@hashicorp.com>
* fix(controller): v2 pod controller errors for acl deletion

* test: fix tests for unsupported L7 TPs
* NET-5392 Replace dev dependencies w/ latest release tags

* go mod tidy

* Adjust api-gateway logic based on changes in consul/api

* Stop setting removed field EnvoyExtensions in test

The field was intentionally removed in hashicorp/consul#19186

* gofmt
* init

* fix help and synopsis

* added some tests

* change log

* some fixes

* rename var name

* tests for get envoy stats

* fix tests

* Update cli/cmd/envoy-stats/envoy_stats.go

Co-authored-by: Thomas Eckert <teckert@hashicorp.com>

* proxy stats command

* fix command options

* pr comment resolved

* fix globaloptions

* fix lint

---------

Co-authored-by: Thomas Eckert <teckert@hashicorp.com>
Helm Chart: Support StatefulSet PVC retention

Add new variable on the Helm chart to define the PVC retention policy for
the StatefulSet

Co-authored-by: Aleix Murtra <alemurbcn@gmail.com>
@hashicorp-cla
Copy link

hashicorp-cla commented Feb 8, 2024

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes


15 out of 16 committers have signed the CLA.

  • hc-github-team-consul-core
  • ndhanushkodi
  • jm96441n
  • wilkermichael
  • Achooo
  • DanStough
  • nathancoleman
  • cthain
  • sophie-gairo
  • roncodingenthusiast
  • zalimeni
  • david-yu
  • curtbushko
  • absolutelightning
  • sarahalsmiller
  • Thomas Eckert

Thomas Eckert seems not to be a GitHub user.
You need a GitHub account to be able to sign the CLA. If you already have a GitHub account, please add the email address used for this commit to your account.

Have you signed the CLA already but the status is still pending? Recheck it.

@wilkermichael
Copy link
Contributor

@sarahalsmiller just double checking if we should close this? or is this a missing backport?

@sarahalsmiller
Copy link
Member

We can close this. This was a nice to have.

auto-merge was automatically disabled February 13, 2024 16:29

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.