-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NET-4992- Kitchen sink gateway test #3196
Conversation
gwv1beta1 "sigs.k8s.io/gateway-api/apis/v1beta1" | ||
) | ||
|
||
// Enabled everything possible, see if anything breaks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥
|
||
// Create gateway class referencing gateway-class-config. | ||
logger.Log(t, "creating controlled gateway class") | ||
createGatewayClass(t, k8sClient, gatewayClassName, gatewayClassControllerName, gatewayParametersRef) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we still need to create the gatewayclass and all that manually?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think managedGatewayClass
defaults to true so we should be able to skip these steps if there isn't anything special about the kitchen-sink-gateway-class-config
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could swap it over to kustomize before I merge it in for sure. I can't remember why it was split out this way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
kitchen-sink-gateway-class-config
does have configuration that utilities the min/max deployment config.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor comment but overall LGTM
* checkpoint * checkpoint, passing test * kitchen sink, NET-4992 * lint issue * clean up unneeded calls --------- Co-authored-by: Sarah Alsmiller <sarah.alsmiller@sarah.alsmiller-RQQ26PQ2L5>
* checkpoint * checkpoint, passing test * kitchen sink, NET-4992 * lint issue * clean up unneeded calls --------- Co-authored-by: Sarah Alsmiller <sarah.alsmiller@sarah.alsmiller-RQQ26PQ2L5>
* checkpoint * checkpoint, passing test * kitchen sink, NET-4992 * lint issue * clean up unneeded calls --------- Co-authored-by: Sarah Alsmiller <sarah.alsmiller@sarah.alsmiller-RQQ26PQ2L5>
Changes proposed in this PR:
How I've tested this PR:
How I expect reviewers to test this PR:
Checklist: