NET-4992- Kitchen sink gateway test #3196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarahalsmiller
added
pr/no-changelog
missylbytes
reviewed
Nov 10, 2023
| gwv1beta1 "sigs.k8s.io/gateway-api/apis/v1beta1" | ||
| ) | ||
|
|
||
| // Enabled everything possible, see if anything breaks. |
jm96441n
reviewed
Nov 10, 2023
|
|
||
| // Create gateway class referencing gateway-class-config. | ||
| logger.Log(t, "creating controlled gateway class") | ||
| createGatewayClass(t, k8sClient, gatewayClassName, gatewayClassControllerName, gatewayParametersRef) |
There was a problem hiding this comment.
do we still need to create the gatewayclass and all that manually?
There was a problem hiding this comment.
I think managedGatewayClass defaults to true so we should be able to skip these steps if there isn't anything special about the kitchen-sink-gateway-class-config.
There was a problem hiding this comment.
I could swap it over to kustomize before I merge it in for sure. I can't remember why it was split out this way.
There was a problem hiding this comment.
kitchen-sink-gateway-class-config does have configuration that utilities the min/max deployment config.
jm96441n
approved these changes
Nov 10, 2023
1 task
davidsow
pushed a commit
to davidsow/consul-k8s
that referenced
this pull request
Nov 13, 2023
* checkpoint * checkpoint, passing test * kitchen sink, NET-4992 * lint issue * clean up unneeded calls --------- Co-authored-by: Sarah Alsmiller <sarah.alsmiller@sarah.alsmiller-RQQ26PQ2L5>
jjti
pushed a commit
that referenced
this pull request
Nov 14, 2023
* checkpoint * checkpoint, passing test * kitchen sink, NET-4992 * lint issue * clean up unneeded calls --------- Co-authored-by: Sarah Alsmiller <sarah.alsmiller@sarah.alsmiller-RQQ26PQ2L5>
sarahalsmiller
added a commit
that referenced
this pull request
Jan 5, 2024
* checkpoint * checkpoint, passing test * kitchen sink, NET-4992 * lint issue * clean up unneeded calls --------- Co-authored-by: Sarah Alsmiller <sarah.alsmiller@sarah.alsmiller-RQQ26PQ2L5>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
How I've tested this PR:
How I expect reviewers to test this PR:
Checklist: