Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix backup-target setting doesn't set to the latest value #1129

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

a110605
Copy link
Collaborator

@a110605 a110605 commented Sep 4, 2024

Summary

Watch settings data to update harvester settings list.

PR Checklist

  • Is this a multi-tenancy feature/bug?
    • Yes, the relevant RBAC changes are at:
  • Do we need to backport changes to the old Rancher UI, such as RKE1?
    • Yes, the relevant PR is at:
  • Are backend engineers aware of UI changes?

Related Issue #
harvester/harvester#4463

Technical notes summary

harvester backend will auto hide (set to null in API response) below three fields once saved the backup target info. See harvester/harvester#4463 (comment)

  • access key id
  • secret access key
  • cert

We just need to refresh the whole settings on UI.

Screenshot/Video

fix_ca.mov

@a110605 a110605 self-assigned this Sep 4, 2024
@a110605 a110605 mentioned this pull request Sep 4, 2024
Copy link
Member

@WebberHuang1118 WebberHuang1118 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the PR.

@a110605 a110605 added the Bug Fix Something isn't working label Sep 4, 2024
Signed-off-by: andy.lee <andy.lee@suse.com>
@a110605 a110605 merged commit 13600c9 into harvester:master Sep 5, 2024
7 checks passed
@a110605
Copy link
Collaborator Author

a110605 commented Sep 5, 2024

@mergify backport release-harvester-v1.4

Copy link

mergify bot commented Sep 5, 2024

backport release-harvester-v1.4

✅ Backports have been created

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Fix Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants