Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix backup-target setting doesn't set to the latest value (backport #1129) #1131

Merged

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Sep 5, 2024

Summary

Watch settings data to update harvester settings list.

PR Checklist

  • Is this a multi-tenancy feature/bug?
    • Yes, the relevant RBAC changes are at:
  • Do we need to backport changes to the old Rancher UI, such as RKE1?
    • Yes, the relevant PR is at:
  • Are backend engineers aware of UI changes?

Related Issue #
harvester/harvester#4463

Technical notes summary

harvester backend will auto hide (set to null in API response) below three fields once saved the backup target info. See harvester/harvester#4463 (comment)

  • access key id
  • secret access key
  • cert

We just need to refresh the whole settings on UI.

Screenshot/Video

fix_ca.mov

This is an automatic backport of pull request #1129 done by [Mergify](https://mergify.com).

Signed-off-by: andy.lee <andy.lee@suse.com>
(cherry picked from commit 13600c9)
@a110605 a110605 requested review from a110605 and torchiaf September 5, 2024 09:11
@a110605 a110605 self-assigned this Sep 5, 2024
@a110605 a110605 added the Backport to v1.4 Backport PR target v1.4 label Sep 5, 2024
Copy link
Collaborator

@torchiaf torchiaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@a110605 a110605 merged commit e659d18 into release-harvester-v1.4 Sep 6, 2024
5 checks passed
@mergify mergify bot deleted the mergify/bp/release-harvester-v1.4/pr-1129 branch September 6, 2024 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backport to v1.4 Backport PR target v1.4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants