Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

settings websocket #913

Closed
wants to merge 1 commit into from

Conversation

WuJun2016
Copy link

@WuJun2016 WuJun2016 commented Aug 30, 2023

Summary

PR Checklist

- Is this a multi-tenancy feature/bug?
- [ ] Yes, the relevant RBAC changes are at:

- Do we need to backport changes to the old Rancher UI, such as RKE1?
- [ ] Yes, the relevant PR is at:

- Are backend engineers aware of UI changes?
- [ ] Yes, the backend owner is:

Fixes #

test step:

  1. Set additive-ca to empty
  2. Configure backup-targe S3
  3. If a websocket pushes backup-target data, check whether the UI display meets the expectations。
  4. websocket may not push data, so you need to repeat the above operation

Occurred changes and/or fixed issues

Technical notes summary

Areas or cases that should be tested

Areas which could experience regressions

Screenshot/Video

@WuJun2016 WuJun2016 marked this pull request as draft August 30, 2023 07:08
@WuJun2016 WuJun2016 force-pushed the backup-target-crash branch from 6156b26 to 5054244 Compare August 30, 2023 07:48
@WuJun2016 WuJun2016 marked this pull request as ready for review August 30, 2023 08:31
@WuJun2016 WuJun2016 added this to the v1.2.1 milestone Aug 30, 2023
@WuJun2016 WuJun2016 added the Bug Fix Something isn't working label Aug 30, 2023
@WuJun2016 WuJun2016 changed the title websocket settings websocket Aug 31, 2023
@a110605 a110605 assigned a110605 and unassigned a110605 Sep 4, 2024
@a110605 a110605 requested a review from torchiaf September 4, 2024 02:48
@a110605 a110605 removed their assignment Sep 4, 2024
@a110605 a110605 self-requested a review September 4, 2024 02:48
@a110605
Copy link
Collaborator

a110605 commented Sep 4, 2024

Use new PR to fix : #1129

@a110605 a110605 closed this Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Fix Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants