fail compile on match exhaustiveness warnings #1264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is stale because it has been open 30 days with no activity. Unless a comment is added or the “stale” label removed, this will be closed in 3 days |
twrichards
force-pushed
the
sbt-error-on-match-exhaust-warnings
branch
from
072d436 to
500e635
Compare
twrichards
force-pushed
the
sbt-error-on-match-exhaust-warnings
branch
from
500e635 to
6d01894
Compare
…t was causing exhaustiveness warning (and therefore now compilation error)
twrichards
force-pushed
the
sbt-error-on-match-exhaust-warnings
branch
from
6d01894 to
5c2324c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like warnings as errors was turned off in 2017 38ec8bd
This reinstates that but just for match exhaustiveness warnings.
Tested and would've caught the issue in #1082 which needed to be fixed in #1262 (yep 180 PRs later).
FIXES required (before this will compile):
app/utils/Retriable.scala:13:58: match may not be exhaustive.[error] It would fail on the following inputs: Cons(), Emptyconf/routes:114:1: match may not be exhaustive.[error] It would fail on the following input: (_, _)