Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add notification case for SkippedDueToPreviousPartialDeploy #1262

Merged
merged 1 commit into from
Oct 9, 2023
Merged

add notification case for SkippedDueToPreviousPartialDeploy #1262

merged 1 commit into from
Oct 9, 2023

Conversation

twrichards
Copy link
Contributor

getting match errors....
image
...when notifying about SkippedDueToPreviousPartialDeploy introduced in #1082

In an ideal world, we could catch such exhaustiveness issues at compile time (beyond the scope of this PR though)

@twrichards twrichards requested review from a team as code owners October 9, 2023 09:53
@twrichards twrichards merged commit e1426b0 into main Oct 9, 2023
1 check passed
@twrichards twrichards deleted the fix-notifications-for-SkippedDueToPreviousPartialDeploy branch October 9, 2023 10:26
@twrichards twrichards mentioned this pull request Oct 9, 2023
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akash1810 akash1810 akash1810 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@twrichards @akash1810