skip scheduled deploys where last deploy was 'partial' to prevent unexpected/problematic behaviour #1082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twrichards
force-pushed
the
skip-scheduled-if-previous-deploy-is-partial
branch
from
d5019e3 to
26234b8
Compare
twrichards
force-pushed
the
skip-scheduled-if-previous-deploy-is-partial
branch
4 times, most recently
from
ee5c680 to
d07f562
Compare
twrichards
added a commit
that referenced
this pull request
Apr 21, 2023
… notification is sent (added as per #1082 (comment))
…xpected/problematic behaviour, but notify users (like when previous deploy is failed, as most likely the partial deploy was temporary)
… notification is sent (added as per #1082 (comment))
twrichards
force-pushed
the
skip-scheduled-if-previous-deploy-is-partial
branch
from
ed1f7a3 to
f6fa8df
Compare
twrichards
added a commit
that referenced
this pull request
Oct 9, 2023
This was referenced Oct 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently, when @guardian/digital-cms were working on https://github.com/guardian/editorial-tools-production-monitoring/pull/316, they needed to do partial deploys (in order to test on secondary instances in PROD, but leave primary instances unaffected), meanwhile riff-raff performed the scheduled deploy for this project, crucially a full deploy, which in turn broke primary instances, this was quickly dealt with but perhaps if someone forgets that they did a partial deploy, then the current behaviour of riff-raff could cause some quite pernicious problems.
So now, if last deploy for a project was 'partial' then the scheduled deployed is skipped but users are notified (just like when previous deploy failed, as most likely the partial deploy was temporary).