SpecialReportAlt improvements / visual bug fixes #26018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ioannakok
commented
Mar 27, 2023
| .fc-sublinks { | ||
| .fc-sublink__title { | ||
| &:before { | ||
| border-top: 1px solid rgba(118, 118, 118, .3); |
ioannakok
commented
Mar 27, 2023
| .fc-item__timestamp, | ||
| .fc-trail__count--commentcount { | ||
| background-color: transparent; | ||
| } |
…d has no SpecialReportAlt pillar
ioannakok
force-pushed
the
ioanna/fix-sublinks-before-gray
branch
from
460ea67
to
9d5e720
Compare
ioannakok
commented
Mar 27, 2023
| .fc-item.fc-item--type-comment.fc-item--pillar-news { | ||
| &.fc-item--type-comment { | ||
| .fc-item__container.u-faux-block-link--hover { | ||
| background-color: darken($special-report-alt-pastel, 5%); |
There was a problem hiding this comment.
| Before | After |
|---|---|
 |
 |
These two issues with the fc-item--type-comment exist in all the palettes. We possibly haven't noticed them because the issues go away once a special report or special report alt tag is added to the article. For the purposes of SpecialReportAlt, I am fixing the avatar background for all the palettes and the hover state only for SpecialReportAltPalette.
ioannakok
changed the title
|
Overdue on FRONTS-PROD, ADMIN-PROD (merged by @ioannakok 31 minutes and 56 seconds ago) What's gone wrong? |
|
Seen on FRONTS-PROD, ADMIN-PROD (merged by @ioannakok 38 minutes and 33 seconds ago)
|
prout-bot
added
Seen-on-ADMIN-PROD
Seen-on-FRONTS-PROD
and removed
Overdue-on-ADMIN-PROD
Overdue-on-FRONTS-PROD
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Fixes a couple of visual bugs for SpecialReportAlt. See comments for screenshots.
Does this change need to be reproduced in dotcom-rendering ?
Screenshots
What is the value of this and can you measure success?
Checklist
Does this affect other platforms?
Does this affect GLabs Paid Content Pages? Should it have support for Paid Content?
Does this change break ad-free?
Does this change update the version of CAPI we're using?
Accessibility test checklist
Tested