Add SpecialReportAltPalette #6335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
⚡️ Lighthouse report for the changes in this PRLighthouse tested 2 URLs Report for Article
Report for Front
|
|
Size Change: -8.34 kB (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
ioannakok
force-pushed
the
special-report-alt-palette
branch
2 times, most recently
from
9d07112
to
c3278a0
Compare
ioannakok
commented
Nov 2, 2022
| @@ -19,6 +21,8 @@ const textCardHeadline = (containerPalette: DCRContainerPalette): string => { | |||
| return '#041F4A'; | |||
| case 'EventAltPalette': | |||
| return '#041F4A'; | |||
| case 'SpecialReportAltPalette': | |||
| return '#2b2b2a'; | |||
There was a problem hiding this comment.
I went with hex here for consistency but wondered why we're not using the source palette references?
There was a problem hiding this comment.
I believe it’s because there is no source value for that specific colour.
There was a problem hiding this comment.
I am keen to attempt replacing these hex values with palette references at some point but indeed I don't know if they all exist in source off the top of my head. Will give it a go at some point and we'll see how that goes!
|
I'm getting some false positive Chromatic diffs for the |
|
@ioannakok Please can we remove the bold headlines and just have them as normal (Bold kicker, medium headline) ? |
ioannakok
force-pushed
the
special-report-alt-palette
branch
from
c3278a0
to
2f71adc
Compare
Done - looks a lot better indeed! Sorry, it was in the designs and missed that. |
mxdvl
approved these changes
Nov 2, 2022
Looks good now - thanks |
HarryFischer
approved these changes
Nov 2, 2022
This was referenced Nov 9, 2022
5 tasks
17 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Adds
SpecialReportAltPalette. DCR should be able to consume the change in the fronts API.Why?
To match designs
Screenshots
Please ignore the wrong sublinks kicker colours. There is a ticket to fix this more general issue.