Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SpecialReportAlt improvements / visual bug fixes #26018

Merged
merged 2 commits into from
Mar 27, 2023
Merged

SpecialReportAlt improvements / visual bug fixes #26018

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3ceaba9
Fix sublinks lines when card is in SpecialReportAlt palette
ioannakok Mar 24, 2023
9d5e720
Fix Opinion card when inside a SpecialReportalt container and the car…
ioannakok Mar 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 30 additions & 0 deletions static/src/stylesheets/module/facia-garnett/_pillars.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -347,6 +347,36 @@ $pillars: (
}
}

section.fc-container--has-palette {
.fc-item--type-comment.fc-item--pillar-news.fc-item--has-cutout {
&.fc-item--type-comment {
.fc-item__avatar {
background-color: transparent;
}

&:hover {
.fc-item__avatar {
background-color: transparent;
}

.fc-item__timestamp,
.fc-trail__count--commentcount {
background-color: transparent;
}
Copy link
Contributor Author

@ioannakok ioannakok Mar 27, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before After
image image

}
}
}
}

section.fc-container--has-palette.fc-container--special-report-alt-palette {
.fc-item.fc-item--type-comment.fc-item--pillar-news {
&.fc-item--type-comment {
.fc-item__container.u-faux-block-link--hover {
background-color: darken($special-report-alt-pastel, 5%);
Copy link
Contributor Author

@ioannakok ioannakok Mar 27, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before After
image image

These two issues with the fc-item--type-comment exist in all the palettes. We possibly haven't noticed them because the issues go away once a special report or special report alt tag is added to the article. For the purposes of SpecialReportAlt, I am fixing the avatar background for all the palettes and the hover state only for SpecialReportAltPalette.

}
}
}
}


.fc-item--pillar-special-report,
Expand Down
10 changes: 10 additions & 0 deletions static/src/stylesheets/module/facia-garnett/_sublinks.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,16 @@
}
}

section.fc-container--special-report-alt-palette {
.fc-sublinks {
.fc-sublink__title {
&:before {
border-top: 1px solid rgba(118, 118, 118, .3);
Copy link
Contributor Author

@ioannakok ioannakok Mar 27, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before After
image image

}
}
}
}

.fc-sublink__title.fc-sublink--pillar-special-report-alt {
@include fs-headline(1);
color: $brightness-7;
Expand Down