Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP - Marji/improve naming for top mentions implementations #25133

Closed

Conversation

marjisound
Copy link
Contributor

What does this change?

Does this change need to be reproduced in dotcom-rendering ?

  • No
  • Yes (please indicate your plans for DCR Implementation)

Screenshots

What is the value of this and can you measure success?

Checklist

Does this affect other platforms?

  • AMP
  • Apps
  • Other (please specify)

Does this affect GLabs Paid Content Pages? Should it have support for Paid Content?

  • No
  • Yes (please give details)

Does this change break ad-free?

  • No
  • It did, but tests caught it and I fixed it
  • It did, but there was no test coverage so I added that then fixed it

Does this change update the version of CAPI we're using?

Accessibility test checklist

Tested

  • Locally
  • On CODE (optional)

@marjisound marjisound changed the base branch from jc/filter-capi-data-auto-filters to main June 21, 2022 18:32
@marjisound marjisound changed the base branch from main to jc/filter-capi-data-auto-filters June 22, 2022 07:48
@marjisound marjisound changed the base branch from jc/filter-capi-data-auto-filters to main June 22, 2022 08:14
@marjisound marjisound changed the base branch from main to jc/filter-capi-data-auto-filters June 22, 2022 08:15
Base automatically changed from jc/filter-capi-data-auto-filters to main June 22, 2022 12:22
@marjisound marjisound mentioned this pull request Jun 23, 2022
2 tasks
@marjisound
Copy link
Contributor Author

Closing this PR as we did some naming improvement in #25152 (review)

@marjisound marjisound closed this Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant