Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP - Marji/improve naming for top mentions implementations #25133

Closed
wants to merge 16 commits into from
Closed

WIP - Marji/improve naming for top mentions implementations #25133

wants to merge 16 commits into from

Commits on Jun 21, 2022

  1. change model TopMentionsDetails to TopicsDetails

    @marjisound
    marjisound committed Jun 21, 2022
    Configuration menu
    Copy the full SHA
    b664db0 View commit details
    Browse the repository at this point in the history

  2. change model TopMentionsResult to TopicResult

    @marjisound
    marjisound committed Jun 21, 2022
    Configuration menu
    Copy the full SHA
    ad7527f View commit details
    Browse the repository at this point in the history

  3. change model TopMentionsTopicType to TopicType

    @marjisound
    marjisound committed Jun 21, 2022
    Configuration menu
    Copy the full SHA
    26f8796 View commit details
    Browse the repository at this point in the history

  4. change model TopMentionsTopic to Topic

    @marjisound
    marjisound committed Jun 21, 2022
    Configuration menu
    Copy the full SHA
    d1adfd8 View commit details
    Browse the repository at this point in the history

  5. change model TopMentionJsonParseException to TopicJsonParseException

    @marjisound
    marjisound committed Jun 21, 2022
    Configuration menu
    Copy the full SHA
    44abd8a View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2022

  1. change top mention variable names in liveblog controller

    @marjisound
    marjisound committed Jun 22, 2022
    Configuration menu
    Copy the full SHA
    69921d6 View commit details
    Browse the repository at this point in the history

  2. change topMentionsService to TopicService

    @marjisound
    marjisound committed Jun 22, 2022
    Configuration menu
    Copy the full SHA
    dbc7ee3 View commit details
    Browse the repository at this point in the history

  3. change topicService function names

    @marjisound
    marjisound committed Jun 22, 2022
    Configuration menu
    Copy the full SHA
    9745c5e View commit details
    Browse the repository at this point in the history

  4. rename topic service file name

    @marjisound
    marjisound committed Jun 22, 2022
    Configuration menu
    Copy the full SHA
    9924f95 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'jc/filter-capi-data-auto-filters' into marji/improve-na… 

    …ming-for-top-mentions-implementations
    @marjisound
    marjisound committed Jun 22, 2022
    Configuration menu
    Copy the full SHA
    e5b35d8 View commit details
    Browse the repository at this point in the history

  6. change variable names for TopicService

    @marjisound
    marjisound committed Jun 22, 2022
    Configuration menu
    Copy the full SHA
    5b55362 View commit details
    Browse the repository at this point in the history

  7. change naming for TopMentionsS3Client

    @marjisound
    marjisound committed Jun 22, 2022
    Configuration menu
    Copy the full SHA
    c0e08e7 View commit details
    Browse the repository at this point in the history

  8. change naming for TopMentionsLifecycle

    @marjisound
    marjisound committed Jun 22, 2022
    Configuration menu
    Copy the full SHA
    eb0f868 View commit details
    Browse the repository at this point in the history

  9. move topic service and s3 client to service.topics

    @marjisound
    marjisound committed Jun 22, 2022
    Configuration menu
    Copy the full SHA
    2101f9f View commit details
    Browse the repository at this point in the history

  10. change top mention naming in LiveBlogCurrentPage

    @marjisound
    marjisound committed Jun 22, 2022
    Configuration menu
    Copy the full SHA
    c288e5c View commit details
    Browse the repository at this point in the history

  11. merge main into marji/improve-naming-for-top-mentions-implementations

    @marjisound
    marjisound committed Jun 22, 2022
    Configuration menu
    Copy the full SHA
    0a23e0d View commit details
    Browse the repository at this point in the history