Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jc/rename top mentions #25152

Closed
wants to merge 6 commits into from
Closed

Jc/rename top mentions #25152

wants to merge 6 commits into from

Conversation

joecowton1
Copy link
Contributor

What does this change?

@alinaboghiu suggested that we rename TopMentionsResult as simply TopMentions.

Does this change need to be reproduced in dotcom-rendering ?

  • No
  • Yes (please indicate your plans for DCR Implementation)

Screenshots

No UI changes.

@joecowton1 joecowton1 requested a review from a team as a code owner June 27, 2022 15:40
@joecowton1 joecowton1 requested a review from a team June 27, 2022 15:41
Copy link
Contributor

@abeddow91 abeddow91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, thanks for doing this!

Copy link
Member

@AshCorr AshCorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fab!

Copy link
Contributor

@marjisound marjisound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for doing it

@joecowton1 joecowton1 closed this Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants