Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ratio condition for Lightbox #20521

Closed
wants to merge 1 commit into from

Conversation

paperboyo
Copy link
Contributor

This allows Lightbox to be opened irregardless of image ratio. IMHO, the condition never made much sense, was put in allegedly to prevent opening looong cartoons which would be unreadable when shrank to vh, but:

  • these cartoons are often interactives anyway (so Lightbox is not available)
  • one doesn’t have to open the Lightbox, if scrolling is preferable, one can do that
  • we shrink images to vh in galleries without asking anyone (and we are right)
  • the ratio in place was too broad anyway
  • the condition prevents me from being able to appreciate good photography

Will fix half of #19768, undoes part of #7647.

Next: #12215

Does this affect other platforms?

  • AMP
  • Apps
  • Other (please specify)
  • Nope

Does this affect GLabs Paid Content Pages? Should it have support for Paid Content?

  • No (only in a good way)
  • Yes (please give details)

Does this change break ad-free?

  • No
  • It did, but tests caught it and I fixed it
  • It did, but there was no test coverage so I added that then fixed it

Accessibility test checklist

Tested

  • Locally
  • On CODE (optional)

@paperboyo
Copy link
Contributor Author

Closed in favour of #20522.

@paperboyo paperboyo closed this Oct 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant