Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Lightbox images fill the screen again #12215

Open
paperboyo opened this issue Mar 9, 2016 · 1 comment
Open

Make Lightbox images fill the screen again #12215

paperboyo opened this issue Mar 9, 2016 · 1 comment

Comments

@paperboyo
Copy link
Contributor

Hello,

To cut long story short, images in the Lightbox should always fill the screen.

Long story:
The lack of this obvious functionality was discussed here, where the only argument for not having it was to punish readers, so that the users would learn to use higher quality images. This problem is mostly gone/solved because of mediaservice. There are plenty of arguments for having this feature, too many for me to list them unprompted :)

Also, since we've used imgIX, images in Lightbox actually were filling it. The lack of fit=max meant we were requesting them upsized from imgIX. That was crazy for all sorts of reasons, but meant that this particular feature was there. It changed in #12079. So we are back to this (e.g. for all old galleries):

get the loupe

Let's get rid of that!

Regards
Mateusz

@paperboyo
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants