Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Images in older articles don't have an option to open images in the image viewer/'lightbox' #19768

Open
ghost opened this issue May 30, 2018 · 2 comments

Comments

@ghost
Copy link

ghost commented May 30, 2018

You can't open images in the image viewer/'lightbox' on older articles.

For example in these articles below:

https://www.theguardian.com/travel/2011/aug/17/10-best-clubs-berlin
https://www.theguardian.com/law/2010/sep/27/government-torture-guidance
https://www.theguardian.com/global/2010/nov/11/4d-man-modern-masculinity

@ghost ghost changed the title Images in older articles don't have an option to open images in the image viewer/fullscreen Images in older articles don't have an option to open images in the image viewer/'lightbox' May 30, 2018
@paperboyo
Copy link
Contributor

paperboyo commented May 31, 2018

Yeah, the site prevents Lightbox on low resolution images like those above – there wouldn’t be much to gain there, although, maybe, one could argue that it would still offer useful functionality on mobile. And it would be consistent.

What I find more objectionable is for the site to also block certain ratio images irregardless of the resolution.

For example in these articles below:

https://www.theguardian.com/artanddesign/2018/apr/15/surface-work-victoria-miro-review-women-abstract-painting
https://www.theguardian.com/culture/picture/2017/dec/02/modern-toss-cartoon-loo-of-the-year-awards

While I understand the intentions here were noble, the effect is I have to scroll around. I hate having to scroll around.
[fixed by https://github.com//pull/20522 👏 ]

We should probably get rid of both restrictions. If not both – just the second one.

@paperboyo
Copy link
Contributor

Also, related to first issue: #12215.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant