Merging Colin's 7_4_12 branch into my 74X heppy head #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@arizzi I merged the PR from CMG, so you can take my heppy_7_4_12 branch and send me a new PR with the commits you were just telling me about. After I have it, I'll port the whole thing to 7_5_X. Then, I will do a PR to CMSSW for both 7_4_X and 7_5_X
…t lepton collection and add PF matching from @jpata
Thanks, Andrea. I will now have a look at your other PR
Several Jet related fixes and features from VHbb
Conflicts: PhysicsTools/Heppy/python/analyzers/objects/autophobj.py
Conflicts: PhysicsTools/Heppy/python/analyzers/objects/autophobj.py
Thanks VHbb team!
HeppyCore heppy_loop: pass parser to main function (needed for error printout)
…_final Conflicts: PhysicsTools/Heppy/python/analyzers/objects/JetAnalyzer.py PhysicsTools/Heppy/python/analyzers/objects/METAnalyzer.py
- discardedJets are made from jets, while noIdDiscardedJets from jetsAllNoID - remove commented out parts - don't apply jetEta cut to jetsAllNoID a second time before cleaning, since it has been applied already within testJetNoID before - make the attaching of neutrinos optional ( attachNeutrinos boolean parameter ) - make the overlap calculation via pfcandidates optional ( checkLeptonPFOverlap boolean )
… 74Xv1 miniAODS (if old74XMiniAODs is set to True), and make adding shifts optional (makeShiftedMETs)
gpetruc
pushed a commit
that referenced
this pull request
Jan 18, 2016
Herwig++: Create config for CMS tune CUETHppS1
gpetruc
pushed a commit
that referenced
this pull request
Jan 31, 2017
stopping throws on duplicate superclusters in the event & other debugging info
gpetruc
pushed a commit
that referenced
this pull request
Aug 14, 2017
…Update_hPFCalib_fromArun HLT PF Calibration update compliant with code changes
gpetruc
pushed a commit
that referenced
this pull request
Aug 16, 2017
…Update_hPFCalib_fromArun (allow empty) HLT PF Calibration update compliant with code changes
gpetruc
pushed a commit
that referenced
this pull request
Feb 15, 2018
use old thresholds when running collapsed 2018
gpetruc
pushed a commit
that referenced
this pull request
Oct 29, 2019
include dump bool to do validation
gpetruc
pushed a commit
that referenced
this pull request
Jul 15, 2020
…ms (L1Trigger/TrackFindingTMTT) (cms-sw#29381) * create separate PRs for the two L1TK packages * Improved KF efficiency at high eta * Moved MC data files to cms-data * Removed old file * Removed KF HLS to put instead in external library * Ran scram b code-format * Delete KF4ParamsComb.h.bak * Delete KF4ParamsCombIV.bak * Delete KF4ParamsCombV2.bak * Delete KF5ParamsComb.h.bak * Delete KF4ParamsComb.cc.bak * Delete KF4ParamsCombIV.bak * Delete KF4ParamsCombV2.bak * Delete KF5ParamsComb.cc.bak * L1 tk integration tmtt pre5 (#7) * Added CMS code style fixes * Removed old file * Reapplied stub b code-format * All code review changes (#13) * Fix clang errors (#14) * fixed clang error * directory for MC txt files * Fixed clang warnings + minor simplifications (#15) * tweak * tweak * Fixed clang warnings and small simplifications * Fixed clang warnings and small simplifications * All remaining review comments addressed (#16) * Replaced vector size with empty function * Simplified DegradeBend and StubWindowSuggest * Fixed more review comments * More review comments * code reformat * Ran exhaustive clang tidy * Added library to BuildFile.xml (#17) * Deleted TrackFindingTMT/data/README (#18) * Added library to BuildFile.xml (This was already done yesterday. Not sure why it appears again) * README file in data directory deleted * Fix review comments (#20) Co-authored-by: Louise Skinnari <louise.skinnari@cern.ch>
gpetruc
pushed a commit
that referenced
this pull request
Mar 8, 2021
updating 11_1_6 to the master branch
gpetruc
pushed a commit
that referenced
this pull request
May 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@cbernet @arizzi @mariadalfonso
This merges from Colin into CMG, so that the outcome should also be mergeable back in Colin's branch.
Beyond fixing the conflicts, the only two other changes are
Despite this, JetAnalyzer is still a mess, with this infinite combinatoric of multiple jet collections with different selections, ids, and cleaning wrt dfferent objects. We should probably clean it up more and if people need multiple versions of the collections they should just run multiple instances.