CMGTools Heppy 7_4_12 (end of 2015 version) #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update heppy_74X branch to 7_4_12
Conflicts: PhysicsTools/HeppyCore/scripts/heppy_batch.py
… for jets failing id (in synch. with SnT), plus added zllmt_* variables and activity anulus for leptons and isotracks (to be synchronized with SnT)
Heppy: add Flag_HBHENoiseIsoFilter to trigger bits in heppy
Conflicts: PhysicsTools/Heppy/python/physicsobjects/Electron.py
Heppy options in batch jobs
Heppy port of 544
… just in the code; put better defaults for prescaleProcessName
Heppy port of 513 + 548
changed medium Muon-ID definition to be in line with CMSSW selector. segmentCompatibility of inner track goes from >=0.8 to >0.8. THIS WILL CHANGE YOUR MUONS! BE CAREFUL ON IMPLEMENTATION!!!
Heppy: sync medium muon id definition with CMSSW implementation
HeppyCore heppy_loop: pass parser to main function (needed for error printout)
…_final Conflicts: PhysicsTools/Heppy/python/analyzers/objects/JetAnalyzer.py PhysicsTools/Heppy/python/analyzers/objects/METAnalyzer.py
- discardedJets are made from jets, while noIdDiscardedJets from jetsAllNoID - remove commented out parts - don't apply jetEta cut to jetsAllNoID a second time before cleaning, since it has been applied already within testJetNoID before - make the attaching of neutrinos optional ( attachNeutrinos boolean parameter ) - make the overlap calculation via pfcandidates optional ( checkLeptonPFOverlap boolean )
gpetruc
referenced
this pull request
in arizzi/cmssw
Jan 7, 2016
… 74Xv1 miniAODS (if old74XMiniAODs is set to True), and make adding shifts optional (makeShiftedMETs)
cbernet
added a commit
that referenced
this pull request
Jan 8, 2016
Thank you, Giovanni. It looks good to me at first sight. I'll do basic tests this morning and will let you know.
|
All basic tests are passing. @arizzi would you prefer to test that everything is fine on the VHbb side on this branch before I port these modifications to 763? Or is it easier for you to do tests in 763 after the port? The thing is that the port from 74X to 76X is quite difficult and error-prone... So after I do the port of CMG's modifications, I'd prefer to close heppy_7_4_12 if possible. Let me both know if this could be a problem for you, and what are your plans concerning developments for 7_4_X. Cheers, |
|
please go straight to 763, we will start from there and send further PR directly on 76X |
|
please let us know once the 76X branch is updated with this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request of all CMG code to upstream Heppy, after merging the upstream heppy into the CMG heppy first to solve the conflict ( the reverse diff between the upstream heppy and the CMG is gpetruc#7 )
@arizzi @mariadalfonso