L1t hgcal centers #16
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gpetruc
reviewed
Aug 27, 2021
| @@ -445,7 +445,7 @@ void L1TCorrelatorLayer1Producer::initSectorsAndRegions(const edm::ParameterSet | |||
| if (etaWidth > 2 * l1ct::Scales::maxAbsEta()) | |||
| throw cms::Exception("Configuration", "caloSectors eta range too large for eta_t data type"); | |||
| for (unsigned int iphi = 0; iphi < phiSlices; ++iphi) { | |||
| float phiCenter = reco::reduceRange(iphi * phiWidth); //align with L1 TrackFinder phi sector indexing for now | |||
| float phiCenter = reco::reduceRange(iphi * phiWidth + M_PI/6.); //align with L1 TrackFinder phi sector indexing for now | |||
There was a problem hiding this comment.
Better update also the comment, e.g. write that in the present geometry the HGCal sector phi centers are at 30, 150, 270 degrees.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussion https://gitlab.cern.ch/cms-cactus/phase2/firmware/correlator-common/-/merge_requests/45