⚠️ New maintainers needed #370
Comments
|
Hey guys, I am very interested in helping maintain gorilla/websocket. I currently deal with a lot of networking in Golang and believe I could be of service to the project and team. |
|
I'm also working on networking/sockets in Golang. Happy to help maintain/contribute ⚡️ |
|
Since people are constantly hammering on |
|
There’s no need for combative language here @binary132. This is an OSS project, primarily maintained by an individual. If (commercial) production systems rely on this package, having those engineers dedicate time to contributing back or helping with triage would be a far more reasonable request vs. suggesting Gary put in more than a “half baked” effort here. Finding maintainers & contributors is really hard. Most requests fall on deaf ears. I don’t blame Gary for putting a clear timeline around this. |
|
@garyburd have you considered the idea of merging into the official exp. stdlib? Thus probably replacing the current websocket implementation? |
|
Nevermjnd, i didnt read the previous comments. Still @garyburd opinion on this regard will be much appreciated! |
|
@glerchundi I agree that the packages should be merged (by replacing the x/net/websocket package), but I do not have time to do the work and no one else has stepped up to do it. Merging the packages does not help with this issue. There are no maintainers for the x/net/websocket package. |
|
What's the status of this project? I'm looking to switch to gorilla/websocket for the control message pin/pong support in my project. |
|
@prologic I'm thinking best course of action is to just contribute. If we need to make any updates/changes fork gorilla/websocket, do whatever is needed, then make a PR. The more people we have helping out the better :D |
|
I stepped down as regular maintainer of this project. I will fix critical bugs during the search for a new maintainer. If you rely on the quality and ongoing maintenance of this package, then please get involved by volunteering to maintain the package or by helping to find a maintainer. If you support any of the people who volunteered to maintain the project, then comment here or send email to the address on my GitHub profile. @MiikeWilliams and @nynhex: Thank you for volunteering to help maintain the project. As noted in the issue, I want to see some consensus on the new maintainer. That has not happened yet. @elithrar Thank you for your help with this project and your comment above. |
|
This all works fine as long as there's enough folks that have "Contributor"
access to the repo? i.e: Can approve/merge PRs etc?
Can I be added to the repo?
In lieu of an "official" maintainer; just expanding the list of who can
"maintain" the repo is "good enough" IHMO.
James Mills / prologic
E: prologic@shortcircuit.net.au
W: prologic.shortcircuit.net.au
…On Tue, May 1, 2018 at 9:45 AM, Gary Burd ***@***.***> wrote:
I stepped down as regular maintainer of this project. I will fix critical
bugs during the search for a new maintainer.
If you rely on the quality and ongoing maintenance of this package, then
please get involved by volunteering to maintain the package or by helping
to find a maintainer. If you support any of the people who volunteered to
maintain the project, then comment here or send email to the address on my
GitHub profile.
@MiikeWilliams <https://github.com/MiikeWilliams> and @nynhex
<https://github.com/nynhex>: Thank you for volunteering to help maintain
the project. As noted in the issue, I want to see some consensus on the new
maintainer. That has not happened yet.
@elithrar <https://github.com/elithrar> Thank you for your help with this
project and your comment above.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#370 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABOv-kRN5QKBJaRMcJl7bJdtfLVieCrlks5tuJE4gaJpZM4TC8KQ>
.
|
|
@garyburd, @kisielk and myself can merge any critical bugs/patches (as Gary
addressed, above), and myself & @kisielk can triage in the meantime. We're
both pretty strapped for time (+ maintain the other Gorilla repos), so
it'll likely be "critical bugs" only.
I don't know where Gary stands on this, but if you start contributing
fixes, documentation & triaging issues for some period to establish
capability & trust, it will help us understand when to dole out write
privileges to the repo.
…On Tue, May 1, 2018 at 9:54 AM James Mills ***@***.***> wrote:
This all works fine as long as there's enough folks that have "Contributor"
access to the repo? i.e: Can approve/merge PRs etc?
Can I be added to the repo?
In lieu of an "official" maintainer; just expanding the list of who can
"maintain" the repo is "good enough" IHMO.
James Mills / prologic
E: ***@***.***
W: prologic.shortcircuit.net.au
On Tue, May 1, 2018 at 9:45 AM, Gary Burd ***@***.***>
wrote:
> I stepped down as regular maintainer of this project. I will fix critical
> bugs during the search for a new maintainer.
>
> If you rely on the quality and ongoing maintenance of this package, then
> please get involved by volunteering to maintain the package or by helping
> to find a maintainer. If you support any of the people who volunteered to
> maintain the project, then comment here or send email to the address on
my
> GitHub profile.
>
> @MiikeWilliams <https://github.com/MiikeWilliams> and @nynhex
> <https://github.com/nynhex>: Thank you for volunteering to help maintain
> the project. As noted in the issue, I want to see some consensus on the
new
> maintainer. That has not happened yet.
>
> @elithrar <https://github.com/elithrar> Thank you for your help with
this
> project and your comment above.
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <#370 (comment)
>,
> or mute the thread
> <
https://github.com/notifications/unsubscribe-auth/ABOv-kRN5QKBJaRMcJl7bJdtfLVieCrlks5tuJE4gaJpZM4TC8KQ
>
> .
>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#370 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABIcOzOwnYM1mqFslZVlGWOmdU7-_F-ks5tuJNNgaJpZM4TC8KQ>
.
|
|
Sounds reasonable
On Tue, May 1, 2018 at 10:02 Matt Silverlock <notifications@github.com>
wrote:
@garyburd, @kisielk and myself can merge any critical bugs/patches (as Gary
addressed, above), and myself & @kisielk can triage in the meantime. We're
both pretty strapped for time (+ maintain the other Gorilla repos), so
it'll likely be "critical bugs" only.
I don't know where Gary stands on this, but if you start contributing
fixes, documentation & triaging issues for some period to establish
capability & trust, it will help us understand when to dole out write
privileges to the repo.
On Tue, May 1, 2018 at 9:54 AM James Mills ***@***.***>
wrote:
> This all works fine as long as there's enough folks that have
"Contributor"
> access to the repo? i.e: Can approve/merge PRs etc?
>
> Can I be added to the repo?
>
> In lieu of an "official" maintainer; just expanding the list of who can
> "maintain" the repo is "good enough" IHMO.
>
>
> James Mills / prologic
>
> E: ***@***.***
> W: prologic.shortcircuit.net.au
>
> On Tue, May 1, 2018 at 9:45 AM, Gary Burd ***@***.***>
> wrote:
>
> > I stepped down as regular maintainer of this project. I will fix
critical
> > bugs during the search for a new maintainer.
> >
> > If you rely on the quality and ongoing maintenance of this package,
then
> > please get involved by volunteering to maintain the package or by
helping
> > to find a maintainer. If you support any of the people who volunteered
to
> > maintain the project, then comment here or send email to the address on
> my
> > GitHub profile.
> >
> > @MiikeWilliams <https://github.com/MiikeWilliams> and @nynhex
> > <https://github.com/nynhex>: Thank you for volunteering to help
maintain
> > the project. As noted in the issue, I want to see some consensus on the
> new
> > maintainer. That has not happened yet.
> >
> > @elithrar <https://github.com/elithrar> Thank you for your help with
> this
> > project and your comment above.
> >
> > —
> > You are receiving this because you were mentioned.
> > Reply to this email directly, view it on GitHub
> > <
#370 (comment)
> >,
> > or mute the thread
> > <
>
https://github.com/notifications/unsubscribe-auth/ABOv-kRN5QKBJaRMcJl7bJdtfLVieCrlks5tuJE4gaJpZM4TC8KQ
> >
> > .
> >
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <#370 (comment)
>,
> or mute the thread
> <
https://github.com/notifications/unsubscribe-auth/AABIcOzOwnYM1mqFslZVlGWOmdU7-_F-ks5tuJNNgaJpZM4TC8KQ
>
> .
>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#370 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABOv-kFg85-WN3J-sixaRdZB1Vehif5Kks5tuJUWgaJpZM4TC8KQ>
.
--
James Mills / prologic
E: prologic@shortcircuit.net.au
W: prologic.shortcircuit.net.au
|
|
So far so good (y) prologic/msgbus@4b954ba |
|
The Gofrs organization would like to help maintain this project. We have filed a help request issue to discuss ways to possibly maintain this. You can also contact us on the Gophers Slack in the #gofrs channel. |
|
@garyburd @elithrar @kisielk I think we in the Gofrs would like to help look after How would y'all like to start down the path of having us look after this repo? My initial thought was to become an administrator on the organization, and to then manage an org team for The Gofrs based on who wants to contribute to the repo. This would allow us to manage membership without needing to take more of your time away from the other projects. |
|
@theckman I am looking for one or more people with a track record implementing RFCs and maintaining a non-trivial open source project. Gofrs team members are welcome to gain this experience by contributing to this project. We need help triaging bugs and reviewing PRs. The current maintainers will handle admin only tasks for those helping out. The Gorilla maintainers want the package to remain at |
|
@garyburd that sounds like a great fit. I've experience not only implementing RFC-compliant software, but having to troubleshoot software that was not fully compliant and causing sporadic issues. It helps you appreciate the importance of maintaining an open source project with RFC compliance and stability being the top priorities. I know that similar experience exists within the rest of the Gofrs organization as well. Building trust through triaging of issues, and raising of PRs, makes sense. I'll happily start putting more of my time in to looking at things at this repository, including refreshing myself on the codebase. I know that @itsjamie, and maybe @jadr2ddude, from Gofrs are explicitly interested in helping as well. |
|
Additional functionality will be considered, but as per history:
• create an issue explaining who the feature is for
• provide an example of the API you wish to change or introduce
• be OK with alternate suggestions - such as writing an example using
existing APIs - is a polite “no” - every new feature is both a new thing
for a user to learn & maintenance burden on a very stretched group of
maintainers 😉
Hope this helps clarify.
…On Sun, Mar 24, 2019 at 7:48 AM Eran Yanay ***@***.***> wrote:
Where does this library stands at the moment?
If additional functionality (not necessarily critical bug fix of some
sort) is added, will it get reviewed and merged?
@garyburd <https://github.com/garyburd> @elithrar
<https://github.com/elithrar> @kisielk <https://github.com/kisielk>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#370 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABIcAJ1DJ3OS6MKSMSUX24vIz6kAmdtks5vZ5A0gaJpZM4TC8KQ>
.
|
Just a quick drive-by to say hello on this issue; we were discussing the status of this project in the Gofrs' slack and I wanted to add myself to the above list. |
|
Posted again on https://groups.google.com/forum/#!topic/golang-nuts/9D2JuYsq5Lo @IngCr3at1on - if you're still interested, let me know. We'd specifically be looking for folks to start triaging, reviewing & writing PRs, and I can provide some limited rights to help, before we consider a "commit bit" given the risk to the project & its users. |
There may be, but it's clear no one wants to maintain a second implementation. For example #87 has been open since October 2015 but from what I can tell, it's just a trivial documentation fix. |
|
Please refrain from side-tracking this thread. |
|
Since this seems to be a touchy subject, I'd like to make a couple suggestions:
This pinned issue is helpful, but I just didn't notice it when submitting a PR. |
|
Any news? Have you found someone? |
|
No, we have not. The folks helping triage have not been interested in
taking over in full (nor do they owe us that).
PRs still get merged and this remains a mature library, so the need for
large scale changes is small.
…On Mon, Feb 8, 2021 at 6:02 AM SystemGlitch ***@***.***> wrote:
Any news? Have you found someone?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#370 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAEQ4A53BIJOEBLYRR5ARDS57VHVANCNFSM4EYLYKIA>
.
|
|
@garyburd while I don't necessarily want to throw my hat in the ring for the role of maintainer of this project, we rely on it for both open source and commercial projects in the organization I work for. (https://github.com/sensu/sensu-go) As such I have a vested interest in seeing the project live on, and so does the company I work for. I'd be interested in assisting with critical bug fixes, security issues, reviewing pull requests, and possibly funding (I have no direct control over funding, but could advocate for it if it would help the project stay alive). I'm not interested in implementing new features, as I feel the feature set of websockets is good enough. I'm also not interested in triaging issues or trimming the issue backlog (and that's why I don't want to step up to be a maintainer, if that's an expected maintainer function). I also feel like the websocket library is in a pretty good place as things stand, so I wouldn't be surprised if my help isn't needed. But if something needs doing to keep the lights on, you have my support. Feel free to reach out, or have Kamil feed me some tasks (I work with him in maintaining another legacy project already). Cheers ✌️ |
|
Any news? 🙁 |
|
Willing to help maintain this |
its a maintenance-only repo, no new development targets, i understand. |
|
Hello, I am also willing to help maintain this. |
Seems like major versions can be considered given the following the following regarding "version 2.0s":
|
|
The Gorilla project has been archived, and is no longer under active maintainenance. You can read more here: https://github.com/gorilla#gorilla-toolkit |
|
@elithrar thanks for the link. It looks like there are new maintainers for the Gorilla projects. I'm very happy to see this! Wishing you all capable developers a happy continuation and collaboration. |
|
Has the Gorilla project found a new maintainer? 🎉This is exciting news, is there an announcement anywhere about the future direction of the project? |
and others
I am stepping down as the maintainer of the gorilla/WebSocket project.
I am looking for a new maintainer for the project. The new maintainer should have a track record of successfully maintaining an open-source project and implementing RFCs.
Potential maintainers can gain the required experience by contributing to this project. I need help triaging issues, reviewing PRs, and fixing issues labeled "help wanted." If you are interested, jump in and start contributing.
If you rely on the quality and ongoing maintenance of this package, please get involved by helping to maintain this package or finding people to help maintain the project.
The text was updated successfully, but these errors were encountered: