tidy and remove empty go.sum

[chappjc]

Summary of Changes

1. tidy and remove empty go.sum

The go.sum included entries for v1.4.0 of this repo.
Running go mod tidy removes these lines (as expected),
so this commit removes the empty go.sum file entirely.
It is not required, only go.mod.

The go.sum was created in #460,
but there are no notes about why the go.sum included these lines.

Note that having the go.sum did not seem to hurt anything, but
it was unneeded since there were no relevant entries in the file.

[IngCr3at1on]

Please read: https://github.com/golang/go/wiki/Modules#should-i-commit-my-gosum-file-as-well-as-my-gomod-file

Edit: interestingly I didn't note the part about tidy removes the lines from the sum (this is because 1.4 doesn't have a module, sorry for confusion there), I also didn't realize that the module file was completely empty so in this case you're correct the sum is not needed. Though I am intrigued by the modules emptiness, I think I missed something lol

Edit 2: it's bad when you've been using something for a while and you never noted it has zero outside dependencies lol, looks good to me but someone else has to merge.

[chappjc]

Serious question: Is this repository maintained?

[IngCr3at1on]

Instead of being rude maybe look at the pinned issue: #370

[chappjc]

@IngCr3at1on I'm sorry to have offended you. I was genuinely was curious what the state of the repository was, although jumping down my throat for asking doesn't seem particularly polite. However, thank you for directing me to the pinned issue. I think a pull request template that linked to that pinned issue would clarify the situation for potential contributors.

Another idea would be to change the repo description ("A fast, well-tested and widely used WebSocket implementation for Go. ") to mention that maintainers are needed.

Again, I apologize that my question came across as rude. That was not my intention.

[IngCr3at1on]

@IngCr3at1on I'm sorry to have offended you. I was genuinely was curious what the state of the repository was, although jumping down my throat for asking doesn't seem particularly polite. However, thank you for directing me to the pinned issue. I think a pull request template that linked to that pinned issue would clarify the situation for potential contributors.

Another idea would be to change the repo description ("A fast, well-tested and widely used WebSocket implementation for Go. ") to mention that maintainers are needed.

Again, I apologize that my question came across as rude. That was not my intention.

I probably misread and assumed a tone that wasn't really there, I should be the one apologizing.
Thank you for the understanding regardless and I am sorry if my reaction was hostile.

[elithrar]

It's worth noting that this isn't a pressing bug/issue (does anyone disagree) and I'd prefer to update go.mod/sum alongside a new release tag.

…

On Fri, Nov 15, 2019 at 3:09 PM Nathan Bass ***@***.***> wrote: @IngCr3at1on <https://github.com/IngCr3at1on> I'm sorry to have offended you. I was genuinely was curious what the state of the repository was, although jumping down my throat for asking doesn't seem particularly polite. However, thank you for directing me to the pinned issue. I think a pull request template that linked to that pinned issue would clarify the situation for potential contributors. Another idea would be to change the repo description ("A fast, well-tested and widely used WebSocket implementation for Go. ") to mention that maintainers are needed. Again, I apologize that my question came across as rude. That was not my intention. I probably misread and assumed a tone that wasn't really there, I should be the one apologizing. Thank you for the understanding regardless and I am sorry if my reaction was hostile. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#550?email_source=notifications&email_token=AAAEQ4D6IM6HHD7QGBYFQNTQT4TZVA5CNFSM4JBLRCZ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEEG7XEY#issuecomment-554564499>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAEQ4GGVBPQ33D6624HW7TQT4TZVANCNFSM4JBLRCZQ> .

[chappjc]

It's worth noting that this isn't a pressing bug/issue (does anyone disagree) and I'd prefer to update go.mod/sum alongside a new release tag.

Nope, it's pretty minor.

[ferhatelmas]

According to the discussion, keeping go.sum might be more consistent even if it's totally empty.

[chappjc]

That's fine too, but it's presently referencing itself in the go.sum. Which way would you prefer, empty or removed?

Although to be honest, I don't think that discussion points to an empty go.sum since the project never had any actual dependencies. @bcmills' comment:

I'm ambivalent about creating the go.sum file unconditionally. If the module really doesn't have any dependencies, then we really don't need to create that file, and some folks may find it annoying for the go command to implicitly create an empty file that they don't need.

For the specific use-case of a Dockerfile template, you can always touch go.sum at some point prior to the build.

But again, I don't care either way.

[elithrar]

See #584

[chappjc]

Would have been happy to go either way. Glad it's resolved though.