Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

require('google-gax') returns errors #249

Closed
stephenplusplus opened this issue Jun 13, 2018 · 9 comments
Closed

require('google-gax') returns errors #249

stephenplusplus opened this issue Jun 13, 2018 · 9 comments
Assignees
@JustinBeckwith @stephenplusplus
Labels
priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. 🚨 This issue needs some love. status: investigating The issue is under investigation, which is determined to be non-trivial. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@stephenplusplus
Copy link
Contributor

I installed only google-gax in a fresh directory (Node v10/npm v6.1.0), and tried to require the module from the Node console:

> node
> require('google-gax')
Error: ENOENT: no such file or directory, scandir '/Users/stephen/dev/play/play-1528906553/google/api'
    at Object.fs.readdirSync (fs.js:895:3)
    at exports.readdir (/Users/stephen/dev/play/play-1528906553/node_modules/@mrmlnc/readdir-enhanced/lib/sync/fs.js:18:20)
    at Object.safeCall [as safe] (/Users/stephen/dev/play/play-1528906553/node_modules/@mrmlnc/readdir-enhanced/lib/call.js:24:8)
    at DirectoryReader.readNextDirectory (/Users/stephen/dev/play/play-1528906553/node_modules/@mrmlnc/readdir-enhanced/lib/directory-reader.js:78:10)
    at Readable.DirectoryReader.stream._read (/Users/stephen/dev/play/play-1528906553/node_modules/@mrmlnc/readdir-enhanced/lib/directory-reader.js:57:18)
    at Readable.read (_stream_readable.js:449:10)
    at readdirSync (/Users/stephen/dev/play/play-1528906553/node_modules/@mrmlnc/readdir-enhanced/lib/sync/index.js:27:21)
    at Function.readdirSyncStat (/Users/stephen/dev/play/play-1528906553/node_modules/@mrmlnc/readdir-enhanced/lib/index.js:34:10)
    at ReaderSync.dynamicApi (/Users/stephen/dev/play/play-1528906553/node_modules/fast-glob/out/providers/reader-sync.js:61:24)
    at ReaderSync.api (/Users/stephen/dev/play/play-1528906553/node_modules/fast-glob/out/providers/reader-sync.js:53:25)
> Error: ENOENT: no such file or directory, scandir '/Users/stephen/dev/play/play-1528906553/google/logging/type'
    at Object.fs.readdirSync (fs.js:895:3)
    at exports.readdir (/Users/stephen/dev/play/play-1528906553/node_modules/@mrmlnc/readdir-enhanced/lib/sync/fs.js:18:20)
    at Object.safeCall [as safe] (/Users/stephen/dev/play/play-1528906553/node_modules/@mrmlnc/readdir-enhanced/lib/call.js:24:8)
    at DirectoryReader.readNextDirectory (/Users/stephen/dev/play/play-1528906553/node_modules/@mrmlnc/readdir-enhanced/lib/directory-reader.js:78:10)
    at Readable.DirectoryReader.stream._read (/Users/stephen/dev/play/play-1528906553/node_modules/@mrmlnc/readdir-enhanced/lib/directory-reader.js:57:18)
    at Readable.read (_stream_readable.js:449:10)
    at readdirSync (/Users/stephen/dev/play/play-1528906553/node_modules/@mrmlnc/readdir-enhanced/lib/sync/index.js:27:21)
    at Function.readdirSyncStat (/Users/stephen/dev/play/play-1528906553/node_modules/@mrmlnc/readdir-enhanced/lib/index.js:34:10)
    at ReaderSync.dynamicApi (/Users/stephen/dev/play/play-1528906553/node_modules/fast-glob/out/providers/reader-sync.js:61:24)
    at ReaderSync.api (/Users/stephen/dev/play/play-1528906553/node_modules/fast-glob/out/providers/reader-sync.js:53:25)
> Error: ENOENT: no such file or directory, scandir '/Users/stephen/dev/play/play-1528906553/google/longrunning'
    at Object.fs.readdirSync (fs.js:895:3)
    at exports.readdir (/Users/stephen/dev/play/play-1528906553/node_modules/@mrmlnc/readdir-enhanced/lib/sync/fs.js:18:20)
    at Object.safeCall [as safe] (/Users/stephen/dev/play/play-1528906553/node_modules/@mrmlnc/readdir-enhanced/lib/call.js:24:8)
    at DirectoryReader.readNextDirectory (/Users/stephen/dev/play/play-1528906553/node_modules/@mrmlnc/readdir-enhanced/lib/directory-reader.js:78:10)
    at Readable.DirectoryReader.stream._read (/Users/stephen/dev/play/play-1528906553/node_modules/@mrmlnc/readdir-enhanced/lib/directory-reader.js:57:18)
    at Readable.read (_stream_readable.js:449:10)
    at readdirSync (/Users/stephen/dev/play/play-1528906553/node_modules/@mrmlnc/readdir-enhanced/lib/sync/index.js:27:21)
    at Function.readdirSyncStat (/Users/stephen/dev/play/play-1528906553/node_modules/@mrmlnc/readdir-enhanced/lib/index.js:34:10)
    at ReaderSync.dynamicApi (/Users/stephen/dev/play/play-1528906553/node_modules/fast-glob/out/providers/reader-sync.js:61:24)
    at ReaderSync.api (/Users/stephen/dev/play/play-1528906553/node_modules/fast-glob/out/providers/reader-sync.js:53:25)
> Error: ENOENT: no such file or directory, scandir '/Users/stephen/dev/play/play-1528906553/google/protobuf'
    at Object.fs.readdirSync (fs.js:895:3)
    at exports.readdir (/Users/stephen/dev/play/play-1528906553/node_modules/@mrmlnc/readdir-enhanced/lib/sync/fs.js:18:20)
    at Object.safeCall [as safe] (/Users/stephen/dev/play/play-1528906553/node_modules/@mrmlnc/readdir-enhanced/lib/call.js:24:8)
    at DirectoryReader.readNextDirectory (/Users/stephen/dev/play/play-1528906553/node_modules/@mrmlnc/readdir-enhanced/lib/directory-reader.js:78:10)
    at Readable.DirectoryReader.stream._read (/Users/stephen/dev/play/play-1528906553/node_modules/@mrmlnc/readdir-enhanced/lib/directory-reader.js:57:18)
    at Readable.read (_stream_readable.js:449:10)
    at readdirSync (/Users/stephen/dev/play/play-1528906553/node_modules/@mrmlnc/readdir-enhanced/lib/sync/index.js:27:21)
    at Function.readdirSyncStat (/Users/stephen/dev/play/play-1528906553/node_modules/@mrmlnc/readdir-enhanced/lib/index.js:34:10)
    at ReaderSync.dynamicApi (/Users/stephen/dev/play/play-1528906553/node_modules/fast-glob/out/providers/reader-sync.js:61:24)
    at ReaderSync.api (/Users/stephen/dev/play/play-1528906553/node_modules/fast-glob/out/providers/reader-sync.js:53:25)
> Error: ENOENT: no such file or directory, scandir '/Users/stephen/dev/play/play-1528906553/google/rpc'
    at Object.fs.readdirSync (fs.js:895:3)
    at exports.readdir (/Users/stephen/dev/play/play-1528906553/node_modules/@mrmlnc/readdir-enhanced/lib/sync/fs.js:18:20)
    at Object.safeCall [as safe] (/Users/stephen/dev/play/play-1528906553/node_modules/@mrmlnc/readdir-enhanced/lib/call.js:24:8)
    at DirectoryReader.readNextDirectory (/Users/stephen/dev/play/play-1528906553/node_modules/@mrmlnc/readdir-enhanced/lib/directory-reader.js:78:10)
    at Readable.DirectoryReader.stream._read (/Users/stephen/dev/play/play-1528906553/node_modules/@mrmlnc/readdir-enhanced/lib/directory-reader.js:57:18)
    at Readable.read (_stream_readable.js:449:10)
    at readdirSync (/Users/stephen/dev/play/play-1528906553/node_modules/@mrmlnc/readdir-enhanced/lib/sync/index.js:27:21)
    at Function.readdirSyncStat (/Users/stephen/dev/play/play-1528906553/node_modules/@mrmlnc/readdir-enhanced/lib/index.js:34:10)
    at ReaderSync.dynamicApi (/Users/stephen/dev/play/play-1528906553/node_modules/fast-glob/out/providers/reader-sync.js:61:24)
    at ReaderSync.api (/Users/stephen/dev/play/play-1528906553/node_modules/fast-glob/out/providers/reader-sync.js:53:25)
> Error: ENOENT: no such file or directory, scandir '/Users/stephen/dev/play/play-1528906553/google/type'
    at Object.fs.readdirSync (fs.js:895:3)
    at exports.readdir (/Users/stephen/dev/play/play-1528906553/node_modules/@mrmlnc/readdir-enhanced/lib/sync/fs.js:18:20)
    at Object.safeCall [as safe] (/Users/stephen/dev/play/play-1528906553/node_modules/@mrmlnc/readdir-enhanced/lib/call.js:24:8)
    at DirectoryReader.readNextDirectory (/Users/stephen/dev/play/play-1528906553/node_modules/@mrmlnc/readdir-enhanced/lib/directory-reader.js:78:10)
    at Readable.DirectoryReader.stream._read (/Users/stephen/dev/play/play-1528906553/node_modules/@mrmlnc/readdir-enhanced/lib/directory-reader.js:57:18)
    at Readable.read (_stream_readable.js:449:10)
    at readdirSync (/Users/stephen/dev/play/play-1528906553/node_modules/@mrmlnc/readdir-enhanced/lib/sync/index.js:27:21)
    at Function.readdirSyncStat (/Users/stephen/dev/play/play-1528906553/node_modules/@mrmlnc/readdir-enhanced/lib/index.js:34:10)
    at ReaderSync.dynamicApi (/Users/stephen/dev/play/play-1528906553/node_modules/fast-glob/out/providers/reader-sync.js:61:24)
    at ReaderSync.api (/Users/stephen/dev/play/play-1528906553/node_modules/fast-glob/out/providers/reader-sync.js:53:25)
> { routingHeader: { fromParams: [Function: fromParams] },
  constructSettings: [Function: constructSettings],
  StreamType:
   { '1': 'SERVER_STREAMING',
     '2': 'CLIENT_STREAMING',
     '3': 'BIDI_STREAMING',
     SERVER_STREAMING: 1,
     CLIENT_STREAMING: 2,
     BIDI_STREAMING: 3 },
  StreamDescriptor: [Function: StreamDescriptor],
  LongrunningDescriptor: [Function: LongrunningDescriptor],
  operation: [Function: operation],
  BundleDescriptor: [Function: BundleDescriptor],
  BundleExecutor: [Function: BundleExecutor],
  PathTemplate: [Function: PathTemplate],
  PageDescriptor: [Function: PageDescriptor],
  createApiCall: [Function: createApiCall],
  grpc:
   { GrpcClient:
      { [Function: GrpcClient]
        _resolveFile: [Function],
        createByteLengthFunction: [Function] },
     GoogleProtoFilesRoot:
      { [Function: GoogleProtoFilesRoot] _findIncludePath: [Function] } },
  lro:
   { [Function: lro]
     SERVICE_ADDRESS: 'longrunning.googleapis.com',
     ALL_SCOPES: [] },
  createByteLengthFunction: undefined,
  version: '0.17.0' }
@stephenplusplus
Copy link
Contributor Author

@JustinBeckwith PTAL!

@JustinBeckwith JustinBeckwith added the triage me I really want to be triaged. label Jun 13, 2018
This was referenced Jun 13, 2018
Closed
Closed
Merged
@crwilcox
Copy link
Contributor

crwilcox commented Jun 15, 2018 •
edited
Loading

Just adding notes. I have v8.11.1 and it works fine.
EDIT: I may have been mistaken and this may have failed.

@stephenplusplus
Copy link
Contributor Author

I tried that version as well as v10.4.1, as well as on another computer (OS X, previously tested on Windows). Same error.

Note that this doesn't happen if you just require('google-gax') from inside a file. It's only when you require('google-gax') in a Node console.

@crwilcox
Copy link
Contributor

I just retried and am seeing issues in, v8.11.3, v10.4.1

crwilcox@redrover ~/scratch> nvm use 10
Now using node v10.4.1 (npm v6.1.0)
crwilcox@redrover ~/scratch> cd testnode10
crwilcox@redrover ~/s/testnode10> npm install google-gax

> grpc@1.12.3 install /Users/crwilcox/scratch/testnode10/node_modules/grpc
> node-pre-gyp install --fallback-to-build --library=static_library

[grpc] Success: "/Users/crwilcox/scratch/testnode10/node_modules/grpc/src/node/extension_binary/node-v64-darwin-x64-unknown/grpc_node.node" is installed via remote

> protobufjs@6.8.6 postinstall /Users/crwilcox/scratch/testnode10/node_modules/protobufjs
> node scripts/postinstall

npm WARN saveError ENOENT: no such file or directory, open '/Users/crwilcox/scratch/testnode10/package.json'
npm notice created a lockfile as package-lock.json. You should commit this file.
npm WARN enoent ENOENT: no such file or directory, open '/Users/crwilcox/scratch/testnode10/package.json'
npm WARN testnode10 No description
npm WARN testnode10 No repository field.
npm WARN testnode10 No README data
npm WARN testnode10 No license field.

+ google-gax@0.17.1
added 312 packages from 305 contributors and audited 2207 packages in 20.022s
found 0 vulnerabilities

crwilcox@redrover ~/s/testnode10> node
> require('google-gax')
Error: ENOENT: no such file or directory, scandir '/Users/crwilcox/scratch/testnode10/google/api'
    at Object.fs.readdirSync (fs.js:895:3)
    at exports.readdir (/Users/crwilcox/scratch/testnode10/node_modules/@mrmlnc/readdir-enhanced/lib/sync/fs.js:18:20)
    at Object.safeCall [as safe] (/Users/crwilcox/scratch/testnode10/node_modules/@mrmlnc/readdir-enhanced/lib/call.js:24:8)
    at DirectoryReader.readNextDirectory (/Users/crwilcox/scratch/testnode10/node_modules/@mrmlnc/readdir-enhanced/lib/directory-reader.js:78:10)
    at Readable.DirectoryReader.stream._read (/Users/crwilcox/scratch/testnode10/node_modules/@mrmlnc/readdir-enhanced/lib/directory-reader.js:57:18)
    at Readable.read (_stream_readable.js:449:10)
    at readdirSync (/Users/crwilcox/scratch/testnode10/node_modules/@mrmlnc/readdir-enhanced/lib/sync/index.js:27:21)
    at Function.readdirSyncStat (/Users/crwilcox/scratch/testnode10/node_modules/@mrmlnc/readdir-enhanced/lib/index.js:34:10)
    at ReaderSync.dynamicApi (/Users/crwilcox/scratch/testnode10/node_modules/fast-glob/out/providers/reader-sync.js:61:24)
    at ReaderSync.api (/Users/crwilcox/scratch/testnode10/node_modules/fast-glob/out/providers/reader-sync.js:53:25)
> Error: ENOENT: no such file or directory, scandir '/Users/crwilcox/scratch/testnode10/google/logging/type'
    at Object.fs.readdirSync (fs.js:895:3)
    at exports.readdir (/Users/crwilcox/scratch/testnode10/node_modules/@mrmlnc/readdir-enhanced/lib/sync/fs.js:18:20)
    at Object.safeCall [as safe] (/Users/crwilcox/scratch/testnode10/node_modules/@mrmlnc/readdir-enhanced/lib/call.js:24:8)
    at DirectoryReader.readNextDirectory (/Users/crwilcox/scratch/testnode10/node_modules/@mrmlnc/readdir-enhanced/lib/directory-reader.js:78:10)
    at Readable.DirectoryReader.stream._read (/Users/crwilcox/scratch/testnode10/node_modules/@mrmlnc/readdir-enhanced/lib/directory-reader.js:57:18)
    at Readable.read (_stream_readable.js:449:10)
    at readdirSync (/Users/crwilcox/scratch/testnode10/node_modules/@mrmlnc/readdir-enhanced/lib/sync/index.js:27:21)
    at Function.readdirSyncStat (/Users/crwilcox/scratch/testnode10/node_modules/@mrmlnc/readdir-enhanced/lib/index.js:34:10)
    at ReaderSync.dynamicApi (/Users/crwilcox/scratch/testnode10/node_modules/fast-glob/out/providers/reader-sync.js:61:24)
    at ReaderSync.api (/Users/crwilcox/scratch/testnode10/node_modules/fast-glob/out/providers/reader-sync.js:53:25)
> Error: ENOENT: no such file or directory, scandir '/Users/crwilcox/scratch/testnode10/google/longrunning'
    at Object.fs.readdirSync (fs.js:895:3)
    at exports.readdir (/Users/crwilcox/scratch/testnode10/node_modules/@mrmlnc/readdir-enhanced/lib/sync/fs.js:18:20)
    at Object.safeCall [as safe] (/Users/crwilcox/scratch/testnode10/node_modules/@mrmlnc/readdir-enhanced/lib/call.js:24:8)
    at DirectoryReader.readNextDirectory (/Users/crwilcox/scratch/testnode10/node_modules/@mrmlnc/readdir-enhanced/lib/directory-reader.js:78:10)
    at Readable.DirectoryReader.stream._read (/Users/crwilcox/scratch/testnode10/node_modules/@mrmlnc/readdir-enhanced/lib/directory-reader.js:57:18)
    at Readable.read (_stream_readable.js:449:10)
    at readdirSync (/Users/crwilcox/scratch/testnode10/node_modules/@mrmlnc/readdir-enhanced/lib/sync/index.js:27:21)
    at Function.readdirSyncStat (/Users/crwilcox/scratch/testnode10/node_modules/@mrmlnc/readdir-enhanced/lib/index.js:34:10)
    at ReaderSync.dynamicApi (/Users/crwilcox/scratch/testnode10/node_modules/fast-glob/out/providers/reader-sync.js:61:24)
    at ReaderSync.api (/Users/crwilcox/scratch/testnode10/node_modules/fast-glob/out/providers/reader-sync.js:53:25)
> Error: ENOENT: no such file or directory, scandir '/Users/crwilcox/scratch/testnode10/google/protobuf'
    at Object.fs.readdirSync (fs.js:895:3)
    at exports.readdir (/Users/crwilcox/scratch/testnode10/node_modules/@mrmlnc/readdir-enhanced/lib/sync/fs.js:18:20)
    at Object.safeCall [as safe] (/Users/crwilcox/scratch/testnode10/node_modules/@mrmlnc/readdir-enhanced/lib/call.js:24:8)
    at DirectoryReader.readNextDirectory (/Users/crwilcox/scratch/testnode10/node_modules/@mrmlnc/readdir-enhanced/lib/directory-reader.js:78:10)
    at Readable.DirectoryReader.stream._read (/Users/crwilcox/scratch/testnode10/node_modules/@mrmlnc/readdir-enhanced/lib/directory-reader.js:57:18)
    at Readable.read (_stream_readable.js:449:10)
    at readdirSync (/Users/crwilcox/scratch/testnode10/node_modules/@mrmlnc/readdir-enhanced/lib/sync/index.js:27:21)
    at Function.readdirSyncStat (/Users/crwilcox/scratch/testnode10/node_modules/@mrmlnc/readdir-enhanced/lib/index.js:34:10)
    at ReaderSync.dynamicApi (/Users/crwilcox/scratch/testnode10/node_modules/fast-glob/out/providers/reader-sync.js:61:24)
    at ReaderSync.api (/Users/crwilcox/scratch/testnode10/node_modules/fast-glob/out/providers/reader-sync.js:53:25)
> Error: ENOENT: no such file or directory, scandir '/Users/crwilcox/scratch/testnode10/google/rpc'
    at Object.fs.readdirSync (fs.js:895:3)
    at exports.readdir (/Users/crwilcox/scratch/testnode10/node_modules/@mrmlnc/readdir-enhanced/lib/sync/fs.js:18:20)
    at Object.safeCall [as safe] (/Users/crwilcox/scratch/testnode10/node_modules/@mrmlnc/readdir-enhanced/lib/call.js:24:8)
    at DirectoryReader.readNextDirectory (/Users/crwilcox/scratch/testnode10/node_modules/@mrmlnc/readdir-enhanced/lib/directory-reader.js:78:10)
    at Readable.DirectoryReader.stream._read (/Users/crwilcox/scratch/testnode10/node_modules/@mrmlnc/readdir-enhanced/lib/directory-reader.js:57:18)
    at Readable.read (_stream_readable.js:449:10)
    at readdirSync (/Users/crwilcox/scratch/testnode10/node_modules/@mrmlnc/readdir-enhanced/lib/sync/index.js:27:21)
    at Function.readdirSyncStat (/Users/crwilcox/scratch/testnode10/node_modules/@mrmlnc/readdir-enhanced/lib/index.js:34:10)
    at ReaderSync.dynamicApi (/Users/crwilcox/scratch/testnode10/node_modules/fast-glob/out/providers/reader-sync.js:61:24)
    at ReaderSync.api (/Users/crwilcox/scratch/testnode10/node_modules/fast-glob/out/providers/reader-sync.js:53:25)
> Error: ENOENT: no such file or directory, scandir '/Users/crwilcox/scratch/testnode10/google/type'
    at Object.fs.readdirSync (fs.js:895:3)
    at exports.readdir (/Users/crwilcox/scratch/testnode10/node_modules/@mrmlnc/readdir-enhanced/lib/sync/fs.js:18:20)
    at Object.safeCall [as safe] (/Users/crwilcox/scratch/testnode10/node_modules/@mrmlnc/readdir-enhanced/lib/call.js:24:8)
    at DirectoryReader.readNextDirectory (/Users/crwilcox/scratch/testnode10/node_modules/@mrmlnc/readdir-enhanced/lib/directory-reader.js:78:10)
    at Readable.DirectoryReader.stream._read (/Users/crwilcox/scratch/testnode10/node_modules/@mrmlnc/readdir-enhanced/lib/directory-reader.js:57:18)
    at Readable.read (_stream_readable.js:449:10)
    at readdirSync (/Users/crwilcox/scratch/testnode10/node_modules/@mrmlnc/readdir-enhanced/lib/sync/index.js:27:21)
    at Function.readdirSyncStat (/Users/crwilcox/scratch/testnode10/node_modules/@mrmlnc/readdir-enhanced/lib/index.js:34:10)
    at ReaderSync.dynamicApi (/Users/crwilcox/scratch/testnode10/node_modules/fast-glob/out/providers/reader-sync.js:61:24)
    at ReaderSync.api (/Users/crwilcox/scratch/testnode10/node_modules/fast-glob/out/providers/reader-sync.js:53:25)
> { routingHeader: { fromParams: [Function: fromParams] },
  constructSettings: [Function: constructSettings],
  StreamType:
   { '1': 'SERVER_STREAMING',
     '2': 'CLIENT_STREAMING',
     '3': 'BIDI_STREAMING',
     SERVER_STREAMING: 1,
     CLIENT_STREAMING: 2,
     BIDI_STREAMING: 3 },
  StreamDescriptor: [Function: StreamDescriptor],
  LongrunningDescriptor: [Function: LongrunningDescriptor],
  operation: [Function: operation],
  BundleDescriptor: [Function: BundleDescriptor],
  BundleExecutor: [Function: BundleExecutor],
  PathTemplate: [Function: PathTemplate],
  PageDescriptor: [Function: PageDescriptor],
  createApiCall: [Function: createApiCall],
  GrpcClient:
   { [Function: GrpcClient]
     _resolveFile: [Function],
     createByteLengthFunction: [Function] },
  GoogleProtoFilesRoot:
   { [Function: GoogleProtoFilesRoot] _findIncludePath: [Function] },
  lro:
   { [Function: lro]
     SERVICE_ADDRESS: 'longrunning.googleapis.com',
     ALL_SCOPES: [] },
  createByteLengthFunction: [Function],
  version: '0.17.1' }

@JustinBeckwith
Copy link
Contributor

I have a suspicion this line has something to do with it:
783cb88#diff-bb99529408df06caafed25d9e0cd083fL39

Digging deeper.

@JustinBeckwith JustinBeckwith added priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. status: investigating The issue is under investigation, which is determined to be non-trivial. labels Jun 15, 2018
@JustinBeckwith JustinBeckwith self-assigned this Jun 15, 2018
@JustinBeckwith JustinBeckwith removed the triage me I really want to be triaged. label Jun 15, 2018
@JustinBeckwith
Copy link
Contributor

So my investigation led me here:
https://github.com/googleapis/nodejs-proto-files/blob/master/load.js#L22

I'm not super familiar with that codebase, so I'm not sure how that's supposed to work. If I add a leading __dirname in with the rest of the path, it seems to work (but tests fail). @alexander-fenster @stephenplusplus any insights on what might be happening here?

@stephenplusplus
Copy link
Contributor Author

I've been looking into this, I should have a PR later today.

@stephenplusplus stephenplusplus self-assigned this Jun 18, 2018
@stephenplusplus stephenplusplus mentioned this issue Jun 18, 2018
Merged
@stephenplusplus
Copy link
Contributor Author

PR! googleapis/nodejs-proto-files#46

stephenplusplus added a commit to googleapis/nodejs-proto-files that referenced this issue Jun 18, 2018
@stephenplusplus
Correctly locate common proto files (#46)
3854fcd 
googleapis/gax-nodejs#249 (comment)
@stephenplusplus
Copy link
Contributor Author

Fixed in googleapis/nodejs-proto-files#46!

@yoshi-automation yoshi-automation added the 🚨 This issue needs some love. label Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JustinBeckwith JustinBeckwith

@stephenplusplus stephenplusplus

Labels
priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. 🚨 This issue needs some love. status: investigating The issue is under investigation, which is determined to be non-trivial. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@JustinBeckwith @crwilcox @stephenplusplus @yoshi-automation