-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update google-gax to the latest version 🚀 #181
Conversation
Codecov Report
@@ Coverage Diff @@
## master #181 +/- ##
==========================================
- Coverage 99.75% 5.88% -93.88%
==========================================
Files 10 3 -7
Lines 1213 306 -907
==========================================
- Hits 1210 18 -1192
- Misses 3 288 +285
Continue to review full report at Codecov.
|
@kolodny, can you please take a look at the failure? |
I didn't see the error on CI, but it could be this one: googleapis/gax-nodejs#249 |
This isn't a trival update. It looks like at the very least the following needs to change // old
var grpc = require('google-gax').grpc().grpc;
var gaxGrpc = gax.grpc(opts);
// new
var grpc = require('google-gax').grpc;
var gaxGrpc = new gax.grpc.GrpcClient(opts); I don't know what else changed. @JustinBeckwith is there a migration doc or something similar? |
Apologies for missing that in the release notes... I added it! That should be the only breaking change. |
It looks like we're also blocked on googleapis/gax-nodejs#250 |
Version 0.17.1 just got published.Update to this version instead 🚀 Release Notesv0.17.1This release fixes a bug with creating new LRO objects. |
I'm closing this in favor of #193 |
Version 0.17.0 of google-gax was just published.
google-gax
The version 0.17.0 is not covered by your current version range.
If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.
It might be worth looking into these changes and trying to get this project onto the latest version of google-gax.
If you have a solid test suite and good coverage, a passing build is a strong indicator that you can take advantage of these changes directly by merging the proposed change into your project. If the build fails or you don’t have such unconditional trust in your tests, this branch is a great starting point for you to work on the update.
Release Notes
v0.17.0This release has a bunch of upgraded dependencies, improved retry logic, and a TypeScript conversion.
da7a0bd refactor: switch to google-auth-library (#244)
66f21c0 fix(package): update google-proto-files to version 0.16.0 (#240)
7589e14 chore(package): update sinon to version 6.0.0 (#246)
4d25439 refactor: improve types (#247)
790ee57 fix: correct json import paths (#245)
9a2c5cb feat: support retryable streaming requests. (#241)
e5e1589 chore: Update sinon to the latest version 🚀 (#239)
ed51887 chore(package): update @types/sinon to version 5.0.0 (#238)
7f45ff6 chore: lock files maintenance (#237)
2d02e7e chore: improve the types (#234)
2805823 chore(package): update mocha to version 5.2.0 (#233)
3360c3e chore: improve types (#232)
1227425 chore: improve types (#231)
def9cd7 docs: improve the readme (#230)
9b09cbe docs: update CI badge (#227)
642147d feat: improve the types (#226)
668726e fix: update dependencies (#223)
21b8d48 fix: un-flake timer test (#225)
210e4c7 fix: re-enable lint via gts (#218)
a720e07 test: fix flaky test (#228)
a949727 chore: use es6 classes (#219)
915e806 chore: use
imports
and @types where possible (#217)783cb88 chore: convert to TypeScript (#214)
5110c2f chore: test on node10 (#216)
b8802b0 chore: lock files maintenance (#215)
11fadf1 chore(package): update sinon to version 5.0.1 (#212)
60855f1 chore(package): update mocha to version 5.1.0 (#211)
Commits
The new version differs by 28 commits.
4c8b242
chore: release 0.17.0 (#248)
4d25439
refactor: improve types (#247)
da7a0bd
refactor: switch to google-auth-library (#244)
66f21c0
fix(package): update google-proto-files to version 0.16.0 (#240)
7589e14
chore(package): update sinon to version 6.0.0 (#246)
790ee57
fix: correct json import paths (#245)
9a2c5cb
feat: support retryable streaming requests. (#241)
e5e1589
chore: Update sinon to the latest version 🚀 (#239)
ed51887
chore(package): update @types/sinon to version 5.0.0 (#238)
7f45ff6
chore: lock files maintenance (#237)
2d02e7e
chore: improve the types (#234)
2805823
chore(package): update mocha to version 5.2.0 (#233)
3360c3e
chore: improve types (#232)
1227425
chore: improve types (#231)
def9cd7
docs: improve the readme (#230)
There are 28 commits in total.
See the full diff
FAQ and help
There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.
Your Greenkeeper bot 🌴