Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update google-gax to the latest version 🚀 #181

Closed
wants to merge 4 commits into from

Conversation

greenkeeper[bot]
Copy link
Contributor

@greenkeeper greenkeeper bot commented Jun 12, 2018

Version 0.17.0 of google-gax was just published.

Dependency google-gax
Current Version 0.16.1
Type dependency

The version 0.17.0 is not covered by your current version range.

If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.

It might be worth looking into these changes and trying to get this project onto the latest version of google-gax.

If you have a solid test suite and good coverage, a passing build is a strong indicator that you can take advantage of these changes directly by merging the proposed change into your project. If the build fails or you don’t have such unconditional trust in your tests, this branch is a great starting point for you to work on the update.


Release Notes v0.17.0

This release has a bunch of upgraded dependencies, improved retry logic, and a TypeScript conversion.

da7a0bd refactor: switch to google-auth-library (#244)
66f21c0 fix(package): update google-proto-files to version 0.16.0 (#240)
7589e14 chore(package): update sinon to version 6.0.0 (#246)
4d25439 refactor: improve types (#247)
790ee57 fix: correct json import paths (#245)
9a2c5cb feat: support retryable streaming requests. (#241)
e5e1589 chore: Update sinon to the latest version 🚀 (#239)
ed51887 chore(package): update @types/sinon to version 5.0.0 (#238)
7f45ff6 chore: lock files maintenance (#237)
2d02e7e chore: improve the types (#234)
2805823 chore(package): update mocha to version 5.2.0 (#233)
3360c3e chore: improve types (#232)
1227425 chore: improve types (#231)
def9cd7 docs: improve the readme (#230)
9b09cbe docs: update CI badge (#227)
642147d feat: improve the types (#226)
668726e fix: update dependencies (#223)
21b8d48 fix: un-flake timer test (#225)
210e4c7 fix: re-enable lint via gts (#218)
a720e07 test: fix flaky test (#228)
a949727 chore: use es6 classes (#219)
915e806 chore: use imports and @types where possible (#217)
783cb88 chore: convert to TypeScript (#214)
5110c2f chore: test on node10 (#216)
b8802b0 chore: lock files maintenance (#215)
11fadf1 chore(package): update sinon to version 5.0.1 (#212)
60855f1 chore(package): update mocha to version 5.1.0 (#211)

Commits

The new version differs by 28 commits.

  • 4c8b242 chore: release 0.17.0 (#248)
  • 4d25439 refactor: improve types (#247)
  • da7a0bd refactor: switch to google-auth-library (#244)
  • 66f21c0 fix(package): update google-proto-files to version 0.16.0 (#240)
  • 7589e14 chore(package): update sinon to version 6.0.0 (#246)
  • 790ee57 fix: correct json import paths (#245)
  • 9a2c5cb feat: support retryable streaming requests. (#241)
  • e5e1589 chore: Update sinon to the latest version 🚀 (#239)
  • ed51887 chore(package): update @types/sinon to version 5.0.0 (#238)
  • 7f45ff6 chore: lock files maintenance (#237)
  • 2d02e7e chore: improve the types (#234)
  • 2805823 chore(package): update mocha to version 5.2.0 (#233)
  • 3360c3e chore: improve types (#232)
  • 1227425 chore: improve types (#231)
  • def9cd7 docs: improve the readme (#230)

There are 28 commits in total.

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.


Your Greenkeeper bot 🌴

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 12, 2018
@codecov
Copy link

codecov bot commented Jun 12, 2018

Codecov Report

Merging #181 into master will decrease coverage by 93.87%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #181       +/-   ##
==========================================
- Coverage   99.75%   5.88%   -93.88%     
==========================================
  Files          10       3        -7     
  Lines        1213     306      -907     
==========================================
- Hits         1210      18     -1192     
- Misses          3     288      +285
Impacted Files Coverage Δ
src/chunktransformer.js 4.91% <0%> (-95.09%) ⬇️
src/index.js 5.12% <0%> (-94.88%) ⬇️
src/mutation.js 8.95% <0%> (-91.05%) ⬇️
src/row.js
src/cluster.js
src/app-profile.js
src/family.js
src/instance.js
src/table.js
src/filter.js

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a356f8a...2474ffd. Read the comment docs.

@ghost ghost assigned sduskis Jun 12, 2018
@sduskis
Copy link
Contributor

sduskis commented Jun 13, 2018

@kolodny, can you please take a look at the failure?

@stephenplusplus
Copy link
Contributor

I didn't see the error on CI, but it could be this one: googleapis/gax-nodejs#249

@kolodny
Copy link
Contributor

kolodny commented Jun 13, 2018

This isn't a trival update. It looks like at the very least the following needs to change

// old
var grpc = require('google-gax').grpc().grpc;
var gaxGrpc = gax.grpc(opts);

// new
var grpc = require('google-gax').grpc;
var gaxGrpc = new gax.grpc.GrpcClient(opts);

I don't know what else changed. @JustinBeckwith is there a migration doc or something similar?

@JustinBeckwith
Copy link
Contributor

Apologies for missing that in the release notes... I added it! That should be the only breaking change.

@kolodny
Copy link
Contributor

kolodny commented Jun 13, 2018

It looks like we're also blocked on googleapis/gax-nodejs#250

greenkeeper bot added a commit that referenced this pull request Jun 13, 2018
@greenkeeper
Copy link
Contributor Author

greenkeeper bot commented Jun 13, 2018

Version 0.17.1 just got published.

Update to this version instead 🚀

Release Notes v0.17.1

This release fixes a bug with creating new LRO objects.

3c2eb48 fix: enable new gax.lro() (#251)

Commits

The new version differs by 2 commits.

  • 7ab9528 chore: release 0.17.1 (#253)
  • 3c2eb48 fix: enable new gax.lro() (#251)

See the full diff

@ghost ghost assigned JustinBeckwith Jun 13, 2018
@sduskis
Copy link
Contributor

sduskis commented Jun 15, 2018

I'm closing this in favor of #193

@sduskis sduskis closed this Jun 15, 2018
@stephenplusplus stephenplusplus deleted the greenkeeper/google-gax-0.17.0 branch June 20, 2018 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement. greenkeeper
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants