-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correctly locate common proto files #46
Correctly locate common proto files #46
Conversation
Codecov Report
@@ Coverage Diff @@
## master #46 +/- ##
=======================================
+ Coverage 82.85% 84% +1.14%
=======================================
Files 3 3
Lines 70 75 +5
=======================================
+ Hits 58 63 +5
Misses 12 12
Continue to review full report at Codecov.
|
@@ -8,3 +8,4 @@ system-test/secrets.js | |||
system-test/*key.json | |||
*.lock | |||
*-lock.js* | |||
google/ |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
@stephenplusplus thank you for doing this 😸 |
source: { | ||
excludePattern: '(^|\\/|\\\\)[._]', | ||
include: [ |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
// Causes the loading of an included proto to check if it is a common | ||
// proto. If it is a common proto, use the google-proto-files proto. | ||
resolvePath(_, includePath) { | ||
includePath = path.normalize(includePath); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
googleapis/gax-nodejs#249 (comment)