feat: support restify 8 #1216
feat: support restify 8 #1216
Conversation
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
googlebot
added
the
cla: no
Codecov Report
@@ Coverage Diff @@
## master #1216 +/- ##
=========================================
Coverage ? 94.65%
=========================================
Files ? 100
Lines ? 6491
Branches ? 514
=========================================
Hits ? 6144
Misses ? 184
Partials ? 163
Continue to review full report at Codecov.
|
…0.0.21 (googleapis#1227) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@opencensus/propagation-stackdriver](https://togithub.com/census-instrumentation/opencensus-node) | dependencies | patch | [`0.0.20` -> `0.0.21`](https://renovatebot.com/diffs/npm/@opencensus%2fpropagation-stackdriver/0.0.20/0.0.21) | --- ### Release Notes <details> <summary>census-instrumentation/opencensus-node</summary> ### [`v0.0.21`](https://togithub.com/census-instrumentation/opencensus-node/blob/master/CHANGELOG.md#​0021---2020-03-30) [Compare Source](https://togithub.com/census-instrumentation/opencensus-node/compare/v0.0.20...v0.0.21) - chore(core): store cls contexts on a Map ([#​786](https://togithub.com/census-instrumentation/opencensus-node/issues/786)) - fix: `opencensus-instrumentation-grpc` reduce vulnerabilities ([#​749](https://togithub.com/census-instrumentation/opencensus-node/issues/749)) </details> --- ### Renovate configuration :date: **Schedule**: "after 9am and before 3pm" (UTC). :vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied. :recycle: **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. :no_bell: **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#googleapis/cloud-trace-nodejs).
Co-authored-by: Alexander Fenster <fenster@google.com> Co-authored-by: Benjamin E. Coe <bencoe@google.com>
This PR was generated using Autosynth. 🌈 Synth log will be available here: https://source.cloud.google.com/results/invocations/9c94202f-63a5-4df0-9d76-871a00f99b85/targets
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [gcp-metadata](https://togithub.com/googleapis/gcp-metadata) | dependencies | major | [`^3.0.0` -> `^4.0.0`](https://renovatebot.com/diffs/npm/gcp-metadata/3.5.0/4.0.0) | --- ### Release Notes <details> <summary>googleapis/gcp-metadata</summary> ### [`v4.0.0`](https://togithub.com/googleapis/gcp-metadata/blob/master/CHANGELOG.md#​400-httpswwwgithubcomgoogleapisgcp-metadatacomparev350v400-2020-03-19) [Compare Source](https://togithub.com/googleapis/gcp-metadata/compare/v3.5.0...v4.0.0) ##### ⚠ BREAKING CHANGES - typescript@3.7.x has breaking changes; compiler now targets es2015 - drops Node 8 from engines field ([#​315](https://togithub.com/googleapis/gcp-metadata/issues/315)) ##### Features - drops Node 8 from engines field ([#​315](https://www.github.com/googleapis/gcp-metadata/issues/315)) ([acb6233](https://www.github.com/googleapis/gcp-metadata/commit/acb62337e8ba7f0b259ae4e553f19c5786207d84)) ##### Build System - switch to latest typescirpt/gts ([#​317](https://www.github.com/googleapis/gcp-metadata/issues/317)) ([fbb7158](https://www.github.com/googleapis/gcp-metadata/commit/fbb7158be62c9f1949b69079e35113be1e10495c)) </details> --- ### Renovate configuration :date: **Schedule**: "after 9am and before 3pm" (UTC). :vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied. :recycle: **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. :no_bell: **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#googleapis/cloud-trace-nodejs).
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly: - [x] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/cloud-trace-nodejs/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [x] Ensure the tests and linter pass - [x] Code coverage does not decrease (if any source code was changed) - [x] Appropriate docs were updated (if necessary) Fixes googleapis#1193 🦕
Co-authored-by: Benjamin E. Coe <bencoe@google.com> Co-authored-by: Justin Beckwith <justin.beckwith@gmail.com>
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to determine that you authored the commits in this PR. Maybe you used a different email address in the git commits than was used to sign the CLA? If someone else authored these commits, then please add them to this pull request and have them confirm that they're okay with them being contributed to Google. If there are co-authors, make sure they're formatted properly. In order to pass this check, please resolve this problem and then comment ℹ️ Googlers: Go here for more info. |
|
@googlebot I fixed it. |
|
@Mistic92 it looks like this didn't work :( Could I trouble you to try rebasing this all to one commit, and force pushing? |
|
I picked this up and landed it in #1250 - apologies for the CLA trouble! |
Fixes #1215 🦕