Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: don't overwrite ci.yml, retire .circleci #1228

Merged
merged 1 commit into from
Mar 31, 2020
Merged

build: don't overwrite ci.yml, retire .circleci #1228

merged 1 commit into from
Mar 31, 2020

Conversation

bcoe
Copy link
Contributor

@bcoe bcoe commented Mar 31, 2020

now that GitHub actions are working:

  1. don't stop them by working by moving to our standard config (with no mongo).
  2. stop running circle-ci.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 31, 2020
@bcoe bcoe requested review from kjin and JustinBeckwith March 31, 2020 21:55
kjin
kjin approved these changes Mar 31, 2020
View reviewed changes
Copy link
Contributor

@kjin kjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although couldn't you synthtool.replace to re-substitute the necessary additions for running with containers? (I guess maybe it's not worth the trouble?)

@bcoe
Copy link
Contributor Author

bcoe commented Mar 31, 2020

@kjin fair point, re: replace, I think in this case I'm comfortable carving out an exception though, vs., needing to get too fancy with a replacement.

@JustinBeckwith JustinBeckwith merged commit 1a66a42 into master Mar 31, 2020
yoshi-automation added a commit that referenced this pull request Apr 1, 2020
@yoshi-automation
build: don't overwrite ci.yml, retire .circleci (#1228)
176729e 
1a66a42
commit 1a66a42
Author: Benjamin E. Coe <bencoe@google.com>
Date:   Tue Mar 31 16:06:09 2020 -0700

    build: don't overwrite ci.yml, retire .circleci (#1228)
Mistic92 pushed a commit to Mistic92/cloud-trace-nodejs that referenced this pull request Apr 15, 2020
@bcoe @Mistic92
build: don't overwrite ci.yml, retire .circleci (googleapis#1228)
2d9ece8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjin kjin kjin approved these changes

@JustinBeckwith JustinBeckwith JustinBeckwith approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bcoe @JustinBeckwith @kjin @googlebot