Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: set up docker containers for github actions #1213

Merged
merged 1 commit into from
Mar 31, 2020

Conversation

kjin
Copy link
Contributor

@kjin kjin commented Mar 6, 2020

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 6, 2020
@codecov
Copy link

codecov bot commented Mar 6, 2020

Codecov Report

Merging #1213 into master will decrease coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1213      +/-   ##
==========================================
- Coverage   94.73%   94.65%   -0.09%     
==========================================
  Files         100      100              
  Lines        6551     6490      -61     
  Branches      514      514              
==========================================
- Hits         6206     6143      -63     
- Misses        182      184       +2     
  Partials      163      163              
Impacted Files Coverage Δ
.mocharc.js 62.50% <0.00%> (-25.00%) ⬇️
test/web-frameworks/connect.ts 76.92% <0.00%> (-0.86%) ⬇️
test/test-cls-ah.ts 90.12% <0.00%> (-0.69%) ⬇️
test/web-frameworks/hapi17.ts 92.30% <0.00%> (-0.38%) ⬇️
test/web-frameworks/hapi8_16.ts 90.47% <0.00%> (-0.23%) ⬇️
test/test-grpc-async-handler.ts 97.01% <0.00%> (-0.17%) ⬇️
test/test-trace-web-frameworks.ts 98.72% <0.00%> (-0.12%) ⬇️
test/plugins/test-cls-bluebird.ts 96.77% <0.00%> (-0.11%) ⬇️
test/test-trace-hapi-tails.ts 97.91% <0.00%> (-0.09%) ⬇️
test/trace.ts 93.50% <0.00%> (-0.09%) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 644adaa...f5fcde1. Read the comment docs.

@kjin kjin force-pushed the gh-actions branch 7 times, most recently from 12c667b to 921dad0 Compare March 7, 2020 01:24
@bcoe
Copy link
Contributor

bcoe commented Mar 11, 2020

@kjin just let me know when you're getting closer to a test configuration you'd like, and we can turn on and off required checks as needed.

@kjin kjin force-pushed the gh-actions branch 6 times, most recently from 90e0198 to 8f45c87 Compare March 30, 2020 23:43
@kjin kjin changed the title [experimental] try setting up docker containers for github actions chore: set up docker containers for github actions Mar 31, 2020
@kjin
Copy link
Contributor Author

kjin commented Mar 31, 2020

Hey @bcoe, sorry for the delay. I think things seem to be green now, PTAL. Thanks!

@kjin kjin requested review from bcoe and JustinBeckwith March 31, 2020 00:15
@bcoe bcoe merged commit 046533b into googleapis:master Mar 31, 2020
Mistic92 pushed a commit to Mistic92/cloud-trace-nodejs that referenced this pull request Apr 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants