Fix caching of target dir for fuzz project
#96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently caching does not work for `fuzz` job which can be verified by looking at Github workflow exec outputs. The main cause of the issue is the config `workspaces: fuzz -> target`. The fuzz target does not use a proper workspace but a separate crate. There is [a pending issue](rust-fuzz/cargo-fuzz#345) discussing that. The `rust-cache` action is executed in the root of the project and is not able to locate `fuzz` directory by workspace name. I decided to list the directories to cache instead of relying on target dir detection which seems to work. I also fixed the path `fuzz/corpus` to `i18n-helpers/fuzz/corpus`. I adjusted the caching condition `save-if` to cache only on `main` builds. I think this makes sense because we don't need to cache PRs which might not get merged or get updated multiple times during review.
kdarkhan
force-pushed
the
fuzz-caching-fix
branch
from
ef7c465
to
963ba2f
Compare
mgeisler
approved these changes
Oct 5, 2023
|
Oh sorry I missed this and thanks for the fix |
I only mentioned it so that we're now three people who know about the cache path 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently caching does not work for
fuzzjob which can be verified by looking at Github workflow outputs.The main cause of the issue is the config
workspaces: fuzz -> target. The fuzz target does not use a proper workspace but a separate crate. There is a pending issue discussing that.The
rust-cacheaction is executed in the root of the project and is not able to locatefuzzdirectory by workspace name.I decided to list the directories to cache instead of relying on target dir detection which seems to work.
I also fixed the path
fuzz/corpustoi18n-helpers/fuzz/corpus.I adjusted the caching condition
save-ifto cache only onmainbuilds. I think this makes sense because we don't need to cache PRs which might not get merged or get updated multiple times during review.