Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix caching of target dir for fuzz project #96

Merged
merged 1 commit into from
Oct 5, 2023

Commits on Oct 4, 2023

  1. Fix caching of target dir for fuzz project

    Currently caching does not work for `fuzz` job which can
    be verified by looking at Github workflow exec outputs.
    
    The main cause of the issue is the config `workspaces: fuzz -> target`.
    The fuzz target does not use a proper workspace but a separate
    crate. There is [a pending issue](rust-fuzz/cargo-fuzz#345)
    discussing that.
    
    The `rust-cache` action is executed in the root of the project and is
    not able to locate `fuzz` directory by workspace name.
    
    I decided to list the directories to cache instead of relying
    on target dir detection which seems to work.
    
    I also fixed the path `fuzz/corpus` to `i18n-helpers/fuzz/corpus`.
    
    I adjusted the caching condition `save-if` to cache only on `main`
    builds. I think this makes sense because we don't need to cache PRs
    which might not get merged or get updated multiple times during review.
    kdarkhan committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    963ba2f View commit details
    Browse the repository at this point in the history