Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor repository to use workspaces #86

Merged
merged 17 commits into from
Sep 25, 2023
Merged

Refactor repository to use workspaces #86

merged 17 commits into from
Sep 25, 2023

Conversation

sakex
Copy link
Collaborator

@sakex sakex commented Sep 22, 2023

No description provided.

Copy link
Collaborator

@mgeisler mgeisler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good!

@mgeisler
Copy link
Collaborator

I think you just need to move the fuzz directory as well?

Copy link
Collaborator

@mgeisler mgeisler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mgeisler
Copy link
Collaborator

We will need to either move the README as well, or create a new smaller README. Otherwise the mdbook-i18n-helpers crate will look odd when we publish it next.

@sakex sakex force-pushed the workspaces branch 4 times, most recently from 4d1a557 to 45e610d Compare September 25, 2023 09:31
kdarkhan and others added 16 commits September 25, 2023 09:43
This refactoring is needed so that fuzzing code can
import and test this logic.
I tested this fuzz target with changes from
google#56 reverted
and it does detect the panic.
Some of the comments has more dashes than necessary — I kept the test
cases that tested extra dashes on purpose.
The data is added to PO files automatically by `msgmerge`. This will
in turn be used when publishing a translation: it allows us to know
which sources goes into a given PO file.

Part of google#16.
This refactoring is needed so that fuzzing code can
import and test this logic.
The data is added to PO files automatically by `msgmerge`. This will
in turn be used when publishing a translation: it allows us to know
which sources goes into a given PO file.

Part of google#16.
The data is added to PO files automatically by `msgmerge`. This will
in turn be used when publishing a translation: it allows us to know
which sources goes into a given PO file.

Part of google#16.
@sakex sakex enabled auto-merge (squash) September 25, 2023 10:06
@sakex sakex merged commit 021f1bf into google:main Sep 25, 2023
5 checks passed
sakex added a commit to sakex/mdbook-i18n-helpers that referenced this pull request Sep 25, 2023
Refactor repository to use workspaces
sakex added a commit to sakex/mdbook-i18n-helpers that referenced this pull request Sep 25, 2023
Refactor repository to use workspaces
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants