-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor repository to use workspaces #86
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks good!
I think you just need to move the fuzz directory as well? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
We will need to either move the README as well, or create a new smaller README. Otherwise the mdbook-i18n-helpers crate will look odd when we publish it next. |
4d1a557
to
45e610d
Compare
This refactoring is needed so that fuzzing code can import and test this logic.
I tested this fuzz target with changes from google#56 reverted and it does detect the panic.
Some of the comments has more dashes than necessary — I kept the test cases that tested extra dashes on purpose.
The data is added to PO files automatically by `msgmerge`. This will in turn be used when publishing a translation: it allows us to know which sources goes into a given PO file. Part of google#16.
This refactoring is needed so that fuzzing code can import and test this logic.
The data is added to PO files automatically by `msgmerge`. This will in turn be used when publishing a translation: it allows us to know which sources goes into a given PO file. Part of google#16.
The data is added to PO files automatically by `msgmerge`. This will in turn be used when publishing a translation: it allows us to know which sources goes into a given PO file. Part of google#16.
Refactor repository to use workspaces
Refactor repository to use workspaces
No description provided.