Stop decoding json from pubsub #554
Conversation
Instead, leave it in base64 like every other format.
|
Welcome @bskaplan! It looks like this is your first PR to google/knative-gcp 🎉 |
|
Hi @bskaplan. Thanks for your PR. I'm waiting for a google member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/ok-to-test |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bskaplan, nachocano The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
The following is the coverage report on the affected files.
|
Instead, leave it in base64 like every other format.
* updating serving and eventing to 0.12 * Stop special-case unmarhalling json from pubsub. (#554) Instead, leave it in base64 like every other format. Co-authored-by: bskaplan <58792807+bskaplan@users.noreply.github.com>
Always leave pubsub message data as b64-encoded, regardless of what the decoded data looks like.
Fixes #546
Release Note