Skip to content
This repository has been archived by the owner on Jun 19, 2022. It is now read-only.

Do not base64 decode PubSub messages #555

Merged
merged 8 commits into from
Feb 14, 2020

Conversation

nachocano
Copy link
Member

Cherry-pick of #554

Proposed Changes

  • Do not base64 decode data in CloudPubSubSource

Release Note

CloudPubSubSource data within the PubSub message is always base64 encoded.

/assign @capri-xiyue

@nachocano
Copy link
Member Author

/hold to confirm by @capri-xiyue

@nachocano
Copy link
Member Author

/hold cancel

@capri-xiyue
Copy link
Contributor

/lgtm

@capri-xiyue
Copy link
Contributor

/approve

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: capri-xiyue, nachocano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [capri-xiyue,nachocano]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit b75eaea into google:release-0.12 Feb 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants