Skip to content
This repository has been archived by the owner on Jun 19, 2022. It is now read-only.

Don't base64 decode data in CloudPubSubSource #546

Closed
nachocano opened this issue Feb 11, 2020 · 2 comments · Fixed by #554
Closed

Don't base64 decode data in CloudPubSubSource #546

nachocano opened this issue Feb 11, 2020 · 2 comments · Fixed by #554
Assignees
Labels
kind/feature-request New feature or request
Milestone

Comments

@nachocano
Copy link
Member

Problem
Currently, if the data is a json, we are unmarshalling it, and sending the raw data. We do not do this for other types, e.g., xml... We agreed not to unmarshall the payload, and just send the data as is (base64 encoded)

Persona:
Which persona is this feature for?
Developer

Exit Criteria
Not base64 decode json in CloudPubSubSource. Add UTs

Time Estimate (optional):
< 1h

Additional context (optional)
Always do this https://github.com/google/knative-gcp/blob/master/pkg/pubsub/adapter/converters/pubsub.go#L72, there is no need for the if statement.

@nachocano nachocano added the kind/feature-request New feature or request label Feb 11, 2020
@nachocano
Copy link
Member Author

/assign @capri-xiyue

@bskaplan
Copy link
Contributor

/assign

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/feature-request New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants