Skip to content
This repository has been archived by the owner on Jun 19, 2022. It is now read-only.

CloudPubSubSource to Push mode #521

Merged
merged 5 commits into from
Jan 24, 2020
Merged

Conversation

nachocano
Copy link
Member

Follow up from #512

Proposed Changes

  • Setting the CloudPubSubSource to always emit Push-compatible format. If users want Pull format, then they should use PullSubscription.
  • Adding a PullSubscriptionArgs struct, otherwise the method signature was getting to cumbersome.
  • Updating docs

Release Note

CloudPubSubSource now emits Push-based format events. If users want to keep on consuming Pull-based format, they should use PullSubscription. 

nachocano added 2 commits January 24, 2020 10:20
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nachocano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nachocano
Copy link
Member Author

/cc @nlopezgi
/cc @capri-xiyue

@knative-prow-robot
Copy link
Contributor

@nachocano: GitHub didn't allow me to request PR reviews from the following users: nlopezgi.

Note that only google members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @nlopezgi
/cc @capri-xiyue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@capri-xiyue
Copy link
Contributor

/lgtm

attempt to fix test
@knative-metrics-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-google-knative-gcp-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/pubsub/adapter/converters/pubsub.go 89.7% 90.0% 0.3
pkg/reconciler/events/pubsub/pubsub.go 76.1% 76.5% 0.4
pkg/reconciler/pubsub/reconciler.go 70.4% 70.7% 0.3

@nachocano
Copy link
Member Author

flaky CAL source

/test pull-google-knative-gcp-integration-tests

@capri-xiyue
Copy link
Contributor

/lgtm

@nachocano nachocano changed the title CloudPubSubSource to Push-based mode CloudPubSubSource to Push mode Jan 24, 2020
@knative-prow-robot knative-prow-robot merged commit 9c6c2a6 into google:master Jan 24, 2020
nachocano added a commit to nachocano/knative-gcp that referenced this pull request Jan 24, 2020
* Setting CloudPubSubSource to be push-based.
Adding a PullSubscriptionArgs struct

* updating docs

* making it public for e2e tests.
attempt to fix test

* rollback the change to boilerplate

* properly unmarshalling the message
knative-prow-robot pushed a commit that referenced this pull request Jan 24, 2020
* updating serving and eventing to 0.12

* CloudPubSubSource to Push mode (#521)

* Setting CloudPubSubSource to be push-based.
Adding a PullSubscriptionArgs struct

* updating docs

* making it public for e2e tests.
attempt to fix test

* rollback the change to boilerplate

* properly unmarshalling the message

* missing files due to the cherry-pick
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants