-
Notifications
You must be signed in to change notification settings - Fork 74
Conversation
Adding a PullSubscriptionArgs struct
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nachocano The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cc @nlopezgi |
@nachocano: GitHub didn't allow me to request PR reviews from the following users: nlopezgi. Note that only google members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
attempt to fix test
The following is the coverage report on the affected files.
|
flaky CAL source /test pull-google-knative-gcp-integration-tests |
/lgtm |
* Setting CloudPubSubSource to be push-based. Adding a PullSubscriptionArgs struct * updating docs * making it public for e2e tests. attempt to fix test * rollback the change to boilerplate * properly unmarshalling the message
* updating serving and eventing to 0.12 * CloudPubSubSource to Push mode (#521) * Setting CloudPubSubSource to be push-based. Adding a PullSubscriptionArgs struct * updating docs * making it public for e2e tests. attempt to fix test * rollback the change to boilerplate * properly unmarshalling the message * missing files due to the cherry-pick
Follow up from #512
Proposed Changes
Release Note