Skip to content
This repository has been archived by the owner on Jun 19, 2022. It is now read-only.

Add labels for topics and pullsubscription #542

Merged
merged 4 commits into from
Feb 11, 2020

Conversation

nlopezgi
Copy link
Contributor

Fixes #509

Proposed Changes

  • Add labels as part of args for MakeTopic / MakePullSubscription
  • Pass the name of the source as one of the labels
  • refactor labels to include receive-adapter
  • refactor MakeTopic to receive a TopicArgs as in CloudPubSubSource to Push mode #521 for MakePullSubscription

Still have some questions about where the info for channel, if necessary at all, comes from.

Release Note

Improved observability of which source or channel or broker a resource belongs to.

@nachocano
Copy link
Member

Looks great! a couple of nits and let's get it in...
Thanks for adding this!

@nlopezgi
Copy link
Contributor Author

done, ptal

@nachocano
Copy link
Member

/lgtm
/approve

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nachocano, nlopezgi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-metrics-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-google-knative-gcp-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/pubsub/reconciler.go 70.7% 71.0% 0.3
pkg/reconciler/pubsub/resources/labels.go Do not exist 100.0%
pkg/reconciler/pubsub/resources/pullsubscription.go 88.9% 87.5% -1.4

@knative-prow-robot knative-prow-robot merged commit cda1f5c into google:master Feb 11, 2020
@nlopezgi nlopezgi deleted the issue509 branch February 11, 2020 15:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add labels to GCP resource to organize/identify them
4 participants