-
Notifications
You must be signed in to change notification settings - Fork 74
Move ConvertToPush method to pubsub.go #512
Conversation
The following is the coverage report on the affected files.
|
@nlopezgi: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
} | ||
return &event, nil | ||
} | ||
|
||
// pushMessage represents the format Pub/Sub uses to push events. | ||
type pushMessage struct { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for making it private!
/lgtm Thanks @nlopezgi !!! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nachocano, nlopezgi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@nlopezgi can you cherry-pick it to release-0.12 branch... We will need this there, together with a follow up that I'll start now |
* move convert to push to pubsub.go * adding new test * collapse convertToPush in convertPubSub * increase testing coverage
Created #520 to cherry pick change into release-0.12 |
Fixes #497
Proposed Changes
Details: