Skip to content
This repository has been archived by the owner on Jun 19, 2022. It is now read-only.

Change EventType of CloudBuildSource #1633

Conversation

bharattkukreja
Copy link
Contributor

@bharattkukreja bharattkukreja commented Aug 25, 2020

Fixes #1608

Proposed Changes

  • Change CE type of CloudBuildSource from com.google.cloud.build.event to google.cloud.cloudbuild.build.v1.statusChanged
  • Update CloudBuildSource data schema

Release Note

BREAKING CHANGES

- CloudBuildSource type is updated to match event types in googleapis/google-cloudevents

ACTION REQUIRED

- Users who depend on the CloudBuildSource "type" value in the trigger filters can create new triggers with new filter value (see details below)

DETAILED CHANGES

1. CloudBuildSource event type was updated to be compliant with https://github.com/googleapis/google-cloudevents/tree/master/proto/google/events/cloud. CloudBuildSource data schema was updated to be https://github.com/googleapis/google-cloudevents/blob/master/proto/google/events/cloud/scheduler/v1/data.proto 
2. Type changes:
   CloudBuildSource: was "com.google.cloud.build.event" => now "google.cloud.cloudbuild.build.v1.statusChanged"

@google-cla google-cla bot added the cla: yes (override cla status due to multiple authors bug) label Aug 25, 2020
@bharattkukreja
Copy link
Contributor Author

cc @nachocano

@nachocano
Copy link
Member

/approve
/lgtm

/hold for @capri-xiyue to look at

@knative-test-reporter-robot

The following jobs failed:

Test name Triggers Retries
pull-google-knative-gcp-wi-tests 2020-08-25 22:58:25.461 +0000 UTC 1/3

Automatically retrying due to test flakiness...
/test pull-google-knative-gcp-wi-tests

@capri-xiyue
Copy link
Contributor

@bharattkukreja Can you also help update the docs of cloud build source with the updated event type and schema https://github.com/google/knative-gcp/blob/master/docs/examples/cloudbuildsource/README.md ?

@bharattkukreja
Copy link
Contributor Author

@capri-xiyue Seems like googleapis/google-cloudevents#57 got merged. I have corrected the schema.

@capri-xiyue
Copy link
Contributor

/lgtm

@capri-xiyue
Copy link
Contributor

/approve

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bharattkukreja, capri-xiyue, nachocano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [capri-xiyue,nachocano]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@capri-xiyue
Copy link
Contributor

/unhold

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved cla: yes (override cla status due to multiple authors bug) lgtm size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change EventType of CloudBuildSource
5 participants