fix: Move the CloudBuild events under google.events.cloud.cloudbuild #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes the proto structure match the event type. (The duplication of "cloud" in the name has been discussed separately.)
jskeet
force-pushed
the
move-cloud-build
branch
from
a6cd0bd
to
c16aad6
Compare
grant
approved these changes
Aug 26, 2020
|
The point of this PR isn't to be consistent with the DNS name for the API. It's to be consistent with the event type, which Scheduler already is. |
|
LGTM for |
|
/lgtm This was definitely a miss in the first place :) Thanks for taking care of this. |
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the proto structure match the event type.
(The duplication of "cloud" in the name has been discussed
separately.)
cc @yolocs. @capri-xiyue