Skip to content
This repository has been archived by the owner on Jun 19, 2022. It is now read-only.

Change EventType of CloudBuildSource #1608

Closed
capri-xiyue opened this issue Aug 19, 2020 · 3 comments · Fixed by #1633
Closed

Change EventType of CloudBuildSource #1608

capri-xiyue opened this issue Aug 19, 2020 · 3 comments · Fixed by #1633
Assignees
@bharattkukreja
Labels
area/sources kind/feature-request New feature or request priority/2 Nice to have feature but doesn't block current release defined by release/* storypoint/2
Milestone
v0.18.0-M1

Comments

@capri-xiyue
Copy link
Contributor

capri-xiyue commented Aug 19, 2020 •
edited
Loading

Problem
Since googleapis/google-cloudevents#40 gets merged, we need to change the CE type of CloudBuildSource from com.google.cloud.build.event to google.cloud.cloudbuild.build.v1.statusChanged

Persona:
Which persona is this feature for?

Exit Criteria
Change CE type of CloudBuildSource from com.google.cloud.build.event to google.cloud.cloudbuild.build.v1.statusChanged and also modify the relevant docs

Time Estimate (optional):
How many developer-days do you think this may take to resolve?

Additional context (optional)
Add any other context about the feature request here.
@nachocano nachocano added priority/2 Nice to have feature but doesn't block current release defined by release/* storypoint/2 labels Aug 19, 2020
@nachocano
Copy link
Member

fyi @bharattkukreja
this is an simple one

@danyinggu danyinggu mentioned this issue Aug 19, 2020
Closed
@nachocano nachocano added this to the v0.18.0-M1 milestone Aug 19, 2020
@danyinggu danyinggu mentioned this issue Aug 19, 2020
Closed
@nachocano
Copy link
Member

See this release notes: #1340

@nachocano
Copy link
Member

Also change the schemaURL to point to the correct one:
https://raw.githubusercontent.com/googleapis/google-cloudevents/master/proto/google/events/cloud/build/v1/data.proto

and see how we are doing it in pubsub for example.

@bharattkukreja bharattkukreja mentioned this issue Aug 25, 2020
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bharattkukreja bharattkukreja

Labels
area/sources kind/feature-request New feature or request priority/2 Nice to have feature but doesn't block current release defined by release/* storypoint/2
Projects
None yet
Milestone
v0.18.0-M1
Development

Successfully merging a pull request may close this issue.

Change EventType of CloudBuildSource bharattkukreja/knative-gcp
3 participants
@nachocano @bharattkukreja @capri-xiyue