Skip to content
This repository has been archived by the owner on Jun 19, 2022. It is now read-only.

Make v1 the storage version of CloudBuildSource #1610

Closed
danyinggu opened this issue Aug 19, 2020 · 1 comment · Fixed by #1797
Closed

Make v1 the storage version of CloudBuildSource #1610

danyinggu opened this issue Aug 19, 2020 · 1 comment · Fixed by #1797
Assignees
@eclipselu
Labels
area/sources kind/feature-request New feature or request kind/good-first-issue priority/2 Nice to have feature but doesn't block current release defined by release/* storypoint/2
Milestone
v0.19.0-M1

Comments

@danyinggu
Copy link
Contributor

danyinggu commented Aug 19, 2020 •
edited by capri-xiyue
Loading

Problem
We will not make v1 the storage version for CloudBuildSource in 0.18 release cut. We will v1 the storage version OF CloudBuildSource in 0.19 release cut, create a stand-alone issue to track this.
Relates to #1413, #1608 and #1482.

Persona:
Which persona is this feature for?

Exit Criteria
v1 is the storage version for CloudBuildSource.

Time Estimate (optional):
How many developer-days do you think this may take to resolve?

Additional context (optional)
Add any other context about the feature request here.

cc @nachocano @capri-xiyue
@danyinggu danyinggu added the kind/feature-request New feature or request label Aug 19, 2020
@danyinggu danyinggu added this to the Backlog milestone Aug 19, 2020
@danyinggu danyinggu mentioned this issue Aug 19, 2020
Closed
@nachocano nachocano added priority/2 Nice to have feature but doesn't block current release defined by release/* storypoint/2 and removed release/2 labels Aug 24, 2020
@danyinggu danyinggu assigned danyinggu and unassigned danyinggu Aug 26, 2020
@nachocano nachocano modified the milestones: Backlog, v0.19.0-M1 Sep 30, 2020
@eclipselu eclipselu mentioned this issue Oct 5, 2020
Merged
@nlopezgi
Copy link
Contributor

Hey Folks, sorry to chime in on this so late after its been closed. We should be avoiding writing any more pre-install jobs and instead rely on post install jobs. Pinging here for future reference as I'm not sure where else to note this.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@eclipselu eclipselu

Labels
area/sources kind/feature-request New feature or request kind/good-first-issue priority/2 Nice to have feature but doesn't block current release defined by release/* storypoint/2
Projects
None yet
Milestone
v0.19.0-M1
Development

Successfully merging a pull request may close this issue.

Flip storage version of CloudBuildSource to v1 eclipselu/knative-gcp
4 participants
@eclipselu @nlopezgi @nachocano @danyinggu