Skip to content
This repository has been archived by the owner on Jun 19, 2022. It is now read-only.

Observability: StackDriver Integration #541

Closed
9 of 16 tasks
nachocano opened this issue Feb 7, 2020 · 7 comments
Closed
9 of 16 tasks

Observability: StackDriver Integration #541

nachocano opened this issue Feb 7, 2020 · 7 comments
Assignees
Labels
area/observability kind/feature-request New feature or request priority/1 Blocks current release defined by release/* label or blocks current milestone release/1
Milestone

Comments

@nachocano
Copy link
Member

nachocano commented Feb 7, 2020

Problem
High-level issue for Observability related tasks.
TL'DR we should be able to integrate with SD metrics, tracing, and logging.

There has been worked done already in this space. We are mainly lacking Source metrics, as it requires integration with SD backend so that users are not charged. But we need to verify traces and logging are actually working as expected. And maybe move away from span-based tracing if it will simplify things. E2E tests need to be added. Our new Broker impl should also support our current metrics (present in the channel-based one, in the Broker ingress and filter pods), as well as tracing

Persona:
Developer

Exit Criteria
Integration with SD metrics in sources, tracing, and logging.

Time Estimate (optional):
???

@nachocano nachocano added the kind/feature-request New feature or request label Feb 7, 2020
@nachocano
Copy link
Member Author

fyi @liu-cong @nlopezgi

@nachocano
Copy link
Member Author

nachocano commented Feb 12, 2020

/assign @ian-mi as I know you have started working on some tracing stuff.
This can be considered an umbrella issue, where you can start putting your findings on... Together with the openCensus patching one in eventing knative/eventing#2052

@nachocano nachocano changed the title Observability StackDriver Observability integrations Mar 2, 2020
@nachocano
Copy link
Member Author

We should scope this down to multiple issues

@nachocano nachocano changed the title StackDriver Observability integrations StackDriver integration (metrics, tracing, logging) Mar 2, 2020
@grantr grantr added area/observability priority/1 Blocks current release defined by release/* label or blocks current milestone release/1 labels Mar 2, 2020
@nachocano
Copy link
Member Author

We should make sure that the new Broker implementation support our current SD metrics

@nachocano nachocano changed the title StackDriver integration (metrics, tracing, logging) Observability: StackDriver Integration Mar 13, 2020
@nachocano
Copy link
Member Author

re: the metris list in eventing https://github.com/knative/eventing/issues?q=is%3Aopen+metrics+author%3Anachocano+label%3Aarea%2Fobservability+. IMO we can safely skip it for now, as they were mainly targeting prometheus backends, and we need to explicitly test our SD integration.

@grantr grantr added this to the Backlog milestone Apr 21, 2020
@Harwayne
Copy link
Contributor

/close

Closing as all the release/1, priority/1 issues are closed. All remaining work items still have their own issues that can be prioritized independently.

@knative-prow-robot
Copy link
Contributor

@Harwayne: Closing this issue.

In response to this:

/close

Closing as all the release/1, priority/1 issues are closed. All remaining work items still have their own issues that can be prioritized independently.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/observability kind/feature-request New feature or request priority/1 Blocks current release defined by release/* label or blocks current milestone release/1
Projects
None yet
Development

No branches or pull requests

5 participants